| Re: [hatari-devel] Screenshots in NEO format -> CI fails / assert |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Screenshots in NEO format -> CI fails / assert
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 27 Jan 2024 22:05:51 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1706393153; bh=OJEblJ+kab5Q88hhhr2veDdTgSwVowxEXmZE6mNi0YA=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=pi5FkADTWV4FlMp/dmgQc4mbpGBsP0Y18L14Gz6qOxjuHYWCqwZ9SbpMRxhs/MQ9F +P9sppqkEckrBmS0diHG9Mbreq1yhDhsAkf1XGuDvpQ/7miiLofhAqF0uTkrKoLloH BPtNcSDRmEhDIgUh5ookRx7UpfVMd3/zfxnJLI4rNEtwcTJokwb4mnFK3Zs1OqYydh A23pxiGhfWiANKPjVXZe+PqDkGsspcofKO4Eb4RzzbaBho+xBWc7pact/DyYXD617t l5x1qWa37RA9u5O0SMEsdYtTiBSMPXD1MeKzv3yw2Q9yMU5r7bVjovf4eaM+wvWWkV 08+iIHxsfxhLA==
Am Sat, 27 Jan 2024 22:27:09 +0100
schrieb Nicolas Pomarède <npomarede@xxxxxxxxxxxx>:
....
> with latest patch from Brad added, there's now a conflict on the CI jobs
>
> On one hand "SDL_PixelFormat *fmt" was reported as unused and made the
> job failed, so it was removed from source
>
> but on the other end thomas added "assert(fmt->BytesPerPixel == 4);"
> which is fine when debug build mode is not enabled, but will fail
> otherwise as "*fmt" is not defined anymore.
>
> Thomas, any idea on how you'd like to handle this ? maybe remove the
> assert ?
Since it's only one spot that uses the value of fmt, I think we can simply
replace it with surface->format. Done now, I hope this fixes the CI
failures.
Thomas