Re: [hatari-devel] Little regression in hatari GUI filesystem in fullscreen mode ?

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 21.3.2024 7.43, Thomas Huth wrote:
> On 20/03/2024 10.53, Eero Tamminen wrote:
> > On 19.3.2024 2.09, Eero Tamminen wrote:
> > > If scrollbar could be changed to use mouse events then the buttons 
> > > should work, but that's more changes than I'm comfortable before 
> > > release.
> >
> > Found an elegant solution for this.  Ignore the mouse position
> > also for scrollbar arrows, like is done for the bar itself!
>
> That's a nice idea, I like it!
>
> > Laurent, does the attached patch fix the button issue for you?
> >
> > Thomas, do you think the previous and this patch would be OK for 
> > release, or would it better to wait until after release?
>
> I think it should be fine. I also gave it a quick try and it seems to 
> work fine for me, and I also reviewed the patches and I think they 
> should not cause any big trouble, so I'd suggest to include them before 
> tagging the release.
>
> Maybe just add an additional comment before SDL_GetMouseState() that the 
> coordinates are not reliabe in full screen mode, so we remember this odd 
> behavior in the future when we ever try to change that code again?

Added (long) comment to the scaling function and pushed the changes.

I guess Mac & Windows Hatari snapshots are soon available, so that
users on those OSes can check the fix to be OK also for them, before
the release.

(As we do not know yet whether the noticed behavior is a generic
issue, or specific just to SDL2 Linux backend.)


	- Eero