Re: [hatari-devel] MODE SENSE update patch

[Uwe Seimet <Uwe.Seimet@xxxxxxxxx>]

Just in case you are interested: These warnings are reported by Eclipse with
the default settings:

Description	Resource	Path	Location	Type
Suspicious semicolon	configuration.c	/hatari/src	line 854	Code Analysis Problem
Variables should be declared one per line to improve readability	configuration.c	/hatari/src	line 510	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 137	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 138	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 537	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 768	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 787	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 853	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 868	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 880	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 895	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 910	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 922	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 934	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 949	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 961	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 983	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 1003	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 1177	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 1203	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 1220	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 1242	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 1259	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 1286	Code Analysis Problem
Variables should be declared one per line to improve readability	dmaSnd.c	/hatari/src	line 1409	Code Analysis Problem
Variables should be declared one per line to improve readability	hdc.c	/hatari/src	line 729	Code Analysis Problem
Variables should be declared one per line to improve readability	hdc.c	/hatari/src	line 730	Code Analysis Problem
Variables should be declared one per line to improve readability	hdc.c	/hatari/src	line 731	Code Analysis Problem
Variables should be declared one per line to improve readability	hdc.c	/hatari/src	line 772	Code Analysis Problem
Variables should be declared one per line to improve readability	hdc.c	/hatari/src	line 799	Code Analysis Problem
Variables should be declared one per line to improve readability	hdc.c	/hatari/src	line 800	Code Analysis Problem


> I just tried it, starting without any project file. I just created a new C
> project for existing sources. Browsing/Navigating the sources and building
> Hatari appears to work fine.
> I suggest that you add these files/folders to .gitignore:
> 
> # Created by the Eclipse IDE (CDT)
> .cproject
> .project
> .settings/
> 
> Best regards
> 
> Uwe
> 
> > Am Sun, 20 Mar 2022 16:45:56 +0100
> > schrieb Uwe Seimet <Uwe.Seimet@xxxxxxxxx>:
> > 
> > > > Sorry, but that sounds like a bad choice of editor, or at least wrong
> > > > settings in your editor. Which editor are you using? All proper editors
> > > > that I know have a way to determine the indentation type automatically from
> > > > the source code that you're opening. I can recommend Geany
> > > > (https://geany.org/), it can also show tabs and spaces in a different way,
> > > > so you can easily spot mistakes while editing the sources.  
> > > 
> > > In the past for C/C++ (which I was hardly using anymore until recently) I was
> > > using vi or emacs. Recently for C/C++ I switched to the Eclipse IDE. I have
> > > not tried Hatari with Eclipse yet. Maybe somebody on this list knows whether
> > > there are any issues, in particular with the build process?
> > 
> > I've never used Eclipse, but it seems like CMake has a generator for
> > Eclipse:
> > 
> > $ cmake -G 2>&1 | grep -i eclipse
> >   Eclipse CDT4 - Ninja         = Generates Eclipse CDT 4.0 project files.
> >   Eclipse CDT4 - Unix Makefiles= Generates Eclipse CDT 4.0 project files.
> > 
> > ... so maybe just give it a try?
> > 
> >  Thomas
> > 
> > 
> 
>