| Re: [hatari-devel] MODE SENSE update patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] MODE SENSE update patch
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 19 Mar 2022 16:26:39 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1647707201; bh=nTrOzIHUxNdJOHG0xqCsSaUr1Z+O/wZuNBgP0czH7fk=; h=Date:From:To:Subject:From; b=ilwzZEpOcFb7TxNH9bZHapjQ2tyOYOxVUnKVIrXYCKkpGJdUA5v3LZm73sqVomUKS xlYFhlHIO8JsfmvS6uv4vpZm7XwXZU9mATrVV2ivtm+zXJjpuXx6uksnzsDn9UzDYP 45sLxa24YTtC+hzaiR2s5Z0xtQRJisjc2smE4pQ+HX/aduPZnO0iTcGyWHGh/NfO6n O/n3XjnNcLVdTFF8Z+4K65eWuwFW2i6CUwd+K5IGsEp3iF3aYgdm+wZF46/pAuUR+Z 2n10uwS5r+tk+hlIqgCzi3dm1aT+WWD0gI7rjmK/QgQADrqUybaZnBUkQbI6f8hIhb VyEb0tX5fCIxw==
Am Fri, 11 Mar 2022 10:40:11 +0100
schrieb Uwe Seimet <Uwe.Seimet@xxxxxxxxx>:
> Hi,
>
> This patch updates mode page 0x3f to return all available pages in the order
> requested by the SCSI specification (i.e. page 0 last).
>
> IMO the implementation of mode page 0x04 is wrong. It is definitely incomplete
> because it ignores some CDB data.
Looks like it had been added by you some years ago:
https://git.tuxfamily.org/hatari/hatari.git/commit/?id=a4789c56520d9bc544a
> If there are no objections I might fix some of these issues with a
> subsequent patch.
.... so sure, if you now think that there's a bug in there, please just go
ahead and fix it! :-)
Thomas