|Re: [hatari-devel] MODE SENSE update patch|
[ Thread Index |
| More lists.tuxfamily.org/hatari-devel Archives
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] MODE SENSE update patch
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sun, 20 Mar 2022 14:51:58 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1647787954; bh=8mBld4EPdrL/AYVyk0ZxNuchGl+7MGQpvMEjA6yu2pA=; h=Date:From:To:Subject:From; b=Q+39qXpKACAyVBo3zRvTq8R+qv7+anvYauXGK41nqEv2orJ/lBu9vXQLxppgg5drb FhYcYdoYM3mA91uWVRE1SniEBhjkkHpdvHVTCsQ3R7WP7rR/HAk70cUYPCzB/5890a w2b5elfG07eHRMZGX/IG1GIsevAPOY94Cqw97ius7fzTArXxtmbPCeqIk4sRJYai/P J+jl5QEM9BkqkxYkY8L7we5y0ddGA3DkJrra4d2RNAlFacKe+xzT60996FCZWtq0gU 5Dn4+ymsoJ34ZWVgKZ2fetzLA3ueCdW7voWXvdes2bIJYzqXlzF5N793g99XjfyE7k XJsJSnbNFEfmg==
Am Sat, 19 Mar 2022 17:55:59 +0100
schrieb Uwe Seimet <Uwe.Seimet@xxxxxxxxx>:
> At least my latest patch fixes the missing header bug. Regarding the DBD bit
> (the ignored CDB data) I do not intend to provide a fix, because it is less
> relevant and ASV does not need it. And because, but please don't feel
> offended, providing patches for Hatari is not really fun, at least for me,
> - All my editor configurations use spaces instead of tabs, and just for
> Hatari I have to be extra careful to use tabs. I don't think that tabs are
> used consistently in the Hatari sources anyway.
Sorry, but that sounds like a bad choice of editor, or at least wrong
settings in your editor. Which editor are you using? All proper editors
that I know have a way to determine the indentation type automatically from
the source code that you're opening. I can recommend Geany
(https://geany.org/), it can also show tabs and spaces in a different way,
so you can easily spot mistakes while editing the sources.
> - As already mentioned in previous postings, the process of providing
> patches is rather complicated. Too much manual work is required, by all who
> are involved. When providing my latest Hatari patches I noticed how much I
> have become used to PRs and UI support to review them, like it is offered by
> GitHub. This must be the well-known GitHub vendor lock-in ;-).
> This is why I try to limit patches to the absolutely necessary scope.
Sorry to hear that, but you also have to understand that it's really not
working either to increase the burdon on the maintainers instead (so that
they have to deal with patches that a way harder to review and debug later).