| Re: [hatari-devel] MODE SENSE update patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] MODE SENSE update patch
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Sat, 19 Mar 2022 17:55:59 +0100
- Authentication-results: strato.com; dkim=none
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1647708960; s=strato-dkim-0002; d=seimet.de; h=In-Reply-To:References:Message-ID:Subject:To:From:Date:Cc:Date:From: Subject:Sender; bh=bUBcOZsHdYTgxbxv6x8DGMAdyZUAmI5rtjpsBYkTuSY=; b=mazDbG0Gk3gYy1HoeP40ZDFvQM5j6Ij3pcl2CFxgAhtO1Z+IDMZbXe5sDfpcy8e/s+ fT+7wJWiaLjnx7yA2Ah3Tloxeiu/UYMkkV6tG971BeHgraykPl84TjSYOnQjf17T5wRq FbVsGweWKntBRK0k73C1vbluD26GaLw7e5Yv9JZG9GAfoXgFyHSYgMPqnKumWYs7bEVM qT4y9zVRYVLTfU9WVc1LRIpSrOYyKkZaV3GfIyBrCqk/y9xlpKr6KL/Gjtdyd1K4NaSH V6nFbV2LWJj9n3SAWvakUOtmTC2ul2jvZ5zAnn1cy7FOW7MJvSlHqkzluDDkn/EfO9QZ TkMw==
Hi Thomas,
> > This patch updates mode page 0x3f to return all available pages in the order
> > requested by the SCSI specification (i.e. page 0 last).
> >
> > IMO the implementation of mode page 0x04 is wrong. It is definitely incomplete
> > because it ignores some CDB data.
>
> Looks like it had been added by you some years ago:
>
> https://git.tuxfamily.org/hatari/hatari.git/commit/?id=a4789c56520d9bc544a
:-) Looks as if there is still room for improvements. I guess I just copied
the code for page 0x00, which is the only page that does not require the
header if I understand the SCSI specification correctly.
> > If there are no objections I might fix some of these issues with a
> > subsequent patch.
>
> ... so sure, if you now think that there's a bug in there, please just go
> ahead and fix it! :-)
At least my latest patch fixes the missing header bug. Regarding the DBD bit
(the ignored CDB data) I do not intend to provide a fix, because it is less
relevant and ASV does not need it. And because, but please don't feel
offended, providing patches for Hatari is not really fun, at least for me,
because:
- All my editor configurations use spaces instead of tabs, and just for
Hatari I have to be extra careful to use tabs. I don't think that tabs are
used consistently in the Hatari sources anyway.
- As already mentioned in previous postings, the process of providing
patches is rather complicated. Too much manual work is required, by all who
are involved. When providing my latest Hatari patches I noticed how much I
have become used to PRs and UI support to review them, like it is offered by
GitHub. This must be the well-known GitHub vendor lock-in ;-).
This is why I try to limit patches to the absolutely necessary scope.
Best regards
Uwe