|Re: [eigen] documentation: the long tutorial|
[ Thread Index |
| More lists.tuxfamily.org/eigen Archives
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] documentation: the long tutorial
- From: Carlos Becker <carlosbecker@xxxxxxxxx>
- Date: Mon, 21 Jun 2010 12:15:29 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type; bh=1T01Xe4R8ZPrEQ2K7uFB+lKq+MrVWUNy0Q/hMb5z3Pw=; b=TQ5vc2TOTCmeS+Nxvbr71SjkzQbsILjv0/uElG56tbWW3J9o++q04tWgR0K1HODv4h hyvyaeCv1Z4ReqbFW+Myc9AAoH25TuZJvulva8OEqFrh4+95z0fNAfFbaFkbt+3Tl6Yd m+IeC5zGYPw7qX9lj2yEhc5MsmKHPtErvqOSA=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=V9h7x7RDbnW39H1KTDLTwAyb8WlyZAa9DT4d7SDnaO/ELFS9tfhs/ZrHUrPLunCDAq kyAre75Dqq5iCtvTOpVI0Gz8YB3AuZWC/VEO3MxOnbWgOUo+F3kzVUxmc5SYqH8a/qEW soYLPIh4I3u5DPGpfMvV092F7gV9FSZ+zzqLQ=
Thanks for the feedback. When you talk about declaring an object as an Array rather than a Matrix, which would be the advantages? Is there any penalty for using matrix.array()? Sorry I am asking about this, I am not sure since I have never used this explicitly.
On Mon, Jun 21, 2010 at 6:58 AM, Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
Great and thank you for your effort.
Only a few minor comments:
- please try to use MatrixXf::Index in your examples like the
minCoeff() code (we just changed that recently)
- I would add "... and indices ..." to "Maximum coefficient .... in a
matrix" since there exists another method taking no parameters which
returns the coefficients only
- for the Array docs I would also mention the special typedefs we have
for Arrays like e.g. ArrayXXf
This is a bit more important since it resembles a little inconsistency
which we need to point out because ArrayXXf is the MatrixXf equivalent
(note the two 'X' vs. one for matrices). Also, sometimes it really
makes sense to declare your objects right away as Arrays without using
the Matrix::array() method.
Ok, that's it for the moment. If I have more time I can look more careful.