| Re: [frogs] First patch: Issue 1275 (name+email for lily-git.tcl) |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: Graham Percival <graham@xxxxxxxxxxxxxxxxx>
- Subject: Re: [frogs] First patch: Issue 1275 (name+email for lily-git.tcl)
- From: Owen Tuz <owentuz@xxxxxxxxx>
- Date: Tue, 16 Nov 2010 01:25:19 +0000
- Cc: frogs@xxxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=Biii/To41ghBu9SCn03249xniWTHKSPmNCi7AXgu8ck=; b=FRASKGNgKllTDezy8yUC84kUN46HEeFUReAJvjlQBOznAoolcXPt63oXltUqZtiM+P Urq0Uwix29srQJae+2oQ11eNFMyZ6pgbLSJS7bnF3ikRACYVK51GVNFhQmKErQ6nCHtZ 3EA2NUy956sQdqgihWqmMuY+tyWYieCfRHviM=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=Aj99+WWU2cLYo0AsEMIMIXniJi3t7XLEQUA5BgGuA08XVOH63SrH4V2I6M8Ta405LV 5ciuJ/2i7qsGvpck0IoRXfPIevsv/9dvfE4xatZkqNfgfRu/tsCEFtTAyRzREi0HIvLU e28PKGSdZnCmljlIU5ai/8dsSKVKc6zyb8DDw=
This looks like a patch to be added after the previous patch was
(theoretically) applied. We generally prefer to have a clear
patch for the entire thing.
.gitconfig won't be created automatically -- installing git just
puts it in a central location. There's absolutely nothing wrong
with an installation (or a user :) if they have no .gitconfig
before running lily-git.tcl.
Take a look at the "file <option> <name>" command, and check the
result of that before trying to open the file.
Cheers,
- Graham
Ah, sorry about that. I tried to avoid exactly that but I'm still getting to know git.
I've kept the "file exists" check in there but it now controls the flag following the "open" command.
If .gitconfig isn't there, the flag a+ opens the file for reading and writing, and will create it if it doesn't exist. If .gitconfig exists, though, it starts access from the end of the file and the script won't find anything in it - hence the need to use a different flag.
That's the last one from me for tonight, thanks for your time checking all this for me! Sorry you still didn't manage to get away without the discussion. Maybe next time.
Cheers (and goodnight!),
Owen
Attachment:
0001-Checks-for-git-user-details.patch
Description: Binary data