Re: [frogs] First patch: Issue 1275 (name+email for lily-git.tcl)

[Graham Percival <graham@xxxxxxxxxxxxxxxxx>]

On Mon, Nov 15, 2010 at 11:37:14PM +0000, Owen Tuz wrote:
>    Right, attached is a revised version (of the whole patch, not a patch to
>    my first patch).

This looks like a patch to be added after the previous patch was
(theoretically) applied.  We generally prefer to have a clear
patch for the entire thing.

> Nothing special - since the script seems to be failing
>    securely enough on its own I thought it would be safe to add code to check
>    only for this specific problem and exit with a popup box telling the user
>    exactly what was wrong.

..gitconfig won't be created automatically -- installing git just
puts it in a central location.  There's absolutely nothing wrong
with an installation (or a user :) if they have no .gitconfig
before running lily-git.tcl.

Take a look at the "file <option> <name>" command, and check the
result of that before trying to open the file.

Cheers,
- Graham

---
----
Join the Frogs!