Re: [frogs] First patch: Issue 1275 (name+email for lily-git.tcl) |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: Graham Percival <graham@xxxxxxxxxxxxxxxxx>
- Subject: Re: [frogs] First patch: Issue 1275 (name+email for lily-git.tcl)
- From: Owen Tuz <owentuz@xxxxxxxxx>
- Date: Mon, 15 Nov 2010 23:37:14 +0000
- Cc: frogs@xxxxxxxxxxx
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=jgmXFFJ7hi6CR15EEv2QfMZWmkzualDX3sR0hL3P3ks=; b=XkoeMvdwIgzbPhq7I07KRYRh8IbZb1ROhADd9s11m5fNxcjTmRTRKqQ6s6xXVb8rq9 lVA/8ImqGJTgUArKyAx6T0Gppn/jOKe5Tp7elAwG+kdxDoFG3cO3WDDqkBYh5+wZbeED hM6QVFTFNnpGUJJDOM7W2a4wsMd4iBOoTfMN0=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=U8dUTNqlHi40ptQKimprCEs4xL73NX1M4dgfLXacvIFil4ycJpRnBWyfoxY4uJwUcE dEWoK34OvKrUNONkaVoAOfA+xBAPXse4cU6QDGzTvqU0JHNVyX3d/3V4XA4/D0edtGFP 0hc1mUxCQcJ5CS8N6sf0PofScAZJ95lhD+bpY=
Hmm. If .gitconfig doesn't exist, then line 66 causes
lily-git.tcl to bail. I don't know if tcl does exceptions, or a
"try to open, and tell me if you failed" function, or what, but
I'm certain there's a way to handle this case.
Cheers,
- Graham
Right, attached is a revised version (of the whole patch, not a patch to my first patch). Nothing special - since the script seems to be failing securely enough on its own I thought it would be safe to add code to check only for this specific problem and exit with a popup box telling the user exactly what was wrong.
Thanks,
Owen
Attachment:
0001-Checks-for-git-user-name-email.patch
Description: Binary data