| [frogs] First patch: Issue 1275 (name+email for lily-git.tcl) |
[ Thread Index |
Date Index
| More lilynet.net/frogs Archives
]
- To: frogs@xxxxxxxxxxx
- Subject: [frogs] First patch: Issue 1275 (name+email for lily-git.tcl)
- From: Owen Tuz <owentuz@xxxxxxxxx>
- Date: Mon, 15 Nov 2010 18:30:49 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:date:message-id :subject:from:to:content-type; bh=1rgiTVqM4P3QN8azYkAAcsO37pSX992hbwA/pCKariw=; b=h+syIjsgBSK5Rj1MajQfWQp8+qw2W6N6tNlVGh5UTr4aM2s3vPRjoalglk3i8sFvh0 7Xey5VDoIFsSwgOWFtSKa8pA8XRHh3RDM4XySWb24/yzTITSnQRW5RKGN3tQRmHxrPlZ wMOp4PPM94CdaH/7ffeea+NoDsCrNI4Tl3hbQ=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=Ohrjq1C/4HPp7F0LJiFCVZIUIoyy5geYQXdaEYk/xJv3f4vo6QknKATZx+uPKE5yw7 4Qg6bVGajYiPLB905NIK0BA/hqBqYaqMsK/BY8BDDzOhTDXo5bVDy/v8YzVs2829VUgY pyuDM2Hjfwg7chlRORPJQrRvk805Te6ECzgQI=
Hi -
Having talked about C++ and Scheme, I went and picked one in tcl/tk instead. The original issue is here: http://code.google.com/p/lilypond/issues/detail?id=1275
It's a small patch which opens the user's global .gitconfig file and checks it for the words "name" and "email". If either one is not found, it opens a popup window asking for them and submits the response using the "git config" command.
It's fairly trivial but I'm assuming that the common practice for Frogs is to post it to the mailing list first? It all seems to work and I'm fairly sure the tcl part is fine but if someone who has some experience with tk could have a look at the code for the popup box in particular just to check it's not a horrible mess, that'd be great.
Thanks,
Owen
Attachment:
0001-Checks-for-git-user-name-email.patch
Description: Binary data