Re: [hatari-devel] Big update to cpu emulation pushed to main repo

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 2/23/20 7:44 PM, Nicolas Pomarède wrote:
> Le 23/02/2020 à 17:42, Christer Solskogen a écrit :
>
> >     include_directories(. ../.. ../includes ${SDL_INCLUDE_DIR} softfloat
> >     ${CMAKE_CURRENT_BINARY_DIR})
> >
> >     This should look for generated .h files into the out of source build
> >     dir
> >     too.
> >
> > That works! :-)
>
> OK, fix pushed to main tree.

I'm getting several compiler warnings:

[  3%] Building C object src/cpu/CMakeFiles/gencpu.dir/gencpu.c.o
/home/eero/work/hatari/src/cpu/gencpu.c:1509:13: warning: 
‘fill_prefetch_next_skipopcode’ defined but not used [-Wunused-function]
 static void fill_prefetch_next_skipopcode(void)
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~

/home/eero/work/hatari/build/src/cpu/cpuemu_31.c: In function 
‘op_4cbb_31_ff’:
/home/eero/work/hatari/build/src/cpu/cpuemu_31.c:21627:9: warning: 
‘tmppc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  srca = x_get_disp_ea_020(tmppc, 0);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/eero/work/hatari/build/src/cpu/cpuemu_31.c: In function 
‘op_4cfb_31_ff’:
/home/eero/work/hatari/build/src/cpu/cpuemu_31.c:21885:9: warning: 
‘tmppc’ may be used uninitialized in this function [-Wmaybe-uninitialized]
  srca = x_get_disp_ea_020(tmppc, 0);
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~

/home/eero/work/hatari/src/cpu/disasm.c: In function ‘asm_parse_mode’:
/home/eero/work/hatari/src/cpu/disasm.c:891:20: warning: comparison of 
integer expressions of different signedness: ‘int’ and ‘size_t’ {aka 
‘long unsigned int’} [-Wsign-compare]
  for (int i = 0; i < _tcslen(s); i++) {
                    ^
/home/eero/work/hatari/src/cpu/disasm.c: In function ‘m68k_disasm_2’:
/home/eero/work/hatari/src/cpu/disasm.c:2020:17: warning: comparison of 
integer expressions of different signedness: ‘int’ and ‘uaecptr’ {aka 
‘unsigned int’} [-Wsign-compare]
   for (i = 0; i < (pc - oldpc) / 2; i++) {
                 ^
/home/eero/work/hatari/src/cpu/disasm.c:2086:17: warning: comparison of 
integer expressions of different signedness: ‘int’ and ‘size_t’ {aka 
‘long unsigned int’} [-Wsign-compare]
     if (bufsize > _tcslen(segout)) {
                 ^
/home/eero/work/hatari/src/cpu/disasm.c: In function ‘sm68k_disasm’:
/home/eero/work/hatari/src/cpu/disasm.c:2171:17: warning: comparison of 
integer expressions of different signedness: ‘int’ and ‘uaecptr’ {aka 
‘unsigned int’} [-Wsign-compare]
   for (i = 0; i < (pc - oldpc) / 2; i++)
                 ^
[ 18%] Building C object src/cpu/CMakeFiles/UaeCpu.dir/fpp_native.c.o
/home/eero/work/hatari/src/cpu/fpp_native.c: In function ‘fp_print’:
/home/eero/work/hatari/src/cpu/fpp_native.c:598:24: warning: comparison 
of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka 
‘long unsigned int’} [-Wsign-compare]
  if (mode == 0 || mode > _tcslen(fsout))
                        ^
[ 19%] Building C object src/cpu/CMakeFiles/UaeCpu.dir/fpp_softfloat.c.o
/home/eero/work/hatari/src/cpu/fpp_softfloat.c: In function ‘fp_printx80’:
/home/eero/work/hatari/src/cpu/fpp_softfloat.c:142:24: warning: 
comparison of integer expressions of different signedness: ‘int’ and 
‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare]
  if (mode == 0 || mode > _tcslen(fsout))
                        ^
[ 19%] Building C object 
src/cpu/CMakeFiles/UaeCpu.dir/softfloat/softfloat.c.o
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c: In function 
‘roundSaveFloatx80Internal’:
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c:150:16: warning: 
comparison of integer expressions of different signedness: ‘uint64_t’ 
{aka ‘long unsigned int’} and ‘int64_t’ {aka ‘long int’} [-Wsign-compare]
     if ( zSig0 < roundIncrement ) {
                ^
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c: In function 
‘getRoundedFloatInternal’:
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c:265:16: warning: 
comparison of integer expressions of different signedness: ‘uint64_t’ 
{aka ‘long unsigned int’} and ‘int64_t’ {aka ‘long int’} [-Wsign-compare]
     if ( zSig0 < roundIncrement ) {
                ^
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c: In function 
‘roundAndPackInt64’:
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c:644:23: warning: 
operand of ?: changes signedness from ‘long int’ to ‘long long unsigned 
int’ due to unsignedness of other operand [-Wsign-compare]
               zSign ? (int64_t) LIT64( 0x8000000000000000 )
                       ^
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c: In function 
‘roundAndPackFloatx80’:
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c:1413:16: warning: 
comparison of integer expressions of different signedness: ‘uint64_t’ 
{aka ‘long unsigned int’} and ‘int64_t’ {aka ‘long int’} [-Wsign-compare]
     if ( zSig0 < roundIncrement ) {
                ^
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c: In function 
‘roundSigAndPackFloatx80’:
/home/eero/work/hatari/src/cpu/softfloat/softfloat.c:1574:16: warning: 
comparison of integer expressions of different signedness: ‘uint64_t’ 
{aka ‘long unsigned int’} and ‘int64_t’ {aka ‘long int’} [-Wsign-compare]
     if ( zSig0 < roundIncrement ) {
                ^

	- Eero