Re: [hatari-devel] Big update to cpu emulation pushed to main repo

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 23/02/2020 à 21:46, Eero Tamminen a écrit :
> Hi,
>
> On 2/23/20 7:44 PM, Nicolas Pomarède wrote:
> > Le 23/02/2020 à 17:42, Christer Solskogen a écrit :
> >
> > >     include_directories(. ../.. ../includes ${SDL_INCLUDE_DIR} softfloat
> > >     ${CMAKE_CURRENT_BINARY_DIR})
> > >
> > >     This should look for generated .h files into the out of source build
> > >     dir
> > >     too.
> > >
> > > That works! :-)
> >
> > OK, fix pushed to main tree.
>
> I'm getting several compiler warnings:

hi

that's the "usual" WinUAE's warning :)

Toni uses a different compiler than us (C++ mode), so some warning are 
only displayed in our case (often, some casts are required)

If Toni feels like fixing these then it will be merged in Hatari, else 
the warnings will remain and we need to add specific compiler flags to 
remove them (as it's already the case) (changing the code just for 
ourselves is a bad idea as it makes merging with WinUAE much more 
difficult in the long term)

Nicolas