Re: [hatari-devel] Re: Hatari SCSI Driver patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Re: Hatari SCSI Driver patch
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Wed, 28 Oct 2015 23:51:07 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1446072667; l=689; s=domk; d=seimet.de; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Subject:To:From:Date; bh=vKZqlj0/jUVC4G/h8gIr+Fi4a15MjICwYFvNCgI4BSU=; b=AhBjDTg3+TXwTS1CtCwCtf+6RlW77SrTjiYWFkteKhzsH2dSFHGFF2H37FpB2HSijzF GLOzvLV5xOQ8oc/thDoYAWcl5N3QeCx0OtLcXCoBopmhdQDee93uUWpGSeShkQTLnxLbL aNU81FCziGH96e+rdqrO8A5CpJa1ORJE+iU=
Hi,
> Then maybe create a HAVE_SCSI_DRIVER in cmake if cmake detects the OS is
> linux, and remove the __linux__
>
> The idea is to centralize all OS specific variables in one place (cmake)
> and then have only HAVE_xxx variables used in sources.
>
> It will be much easier to extend Hatari to other OS this way (for
> example, maybe BSD can be built with nf_scsi driver, but it might not
> define __linux__ ?)
I see your point, but I think it is very unlikely that a different OS
handles this the same way, i.e. the existing code would work with a
non-Linux system. The SG driver, which provides the low level SCSI
interface, is very Linux specific.
Take care
Uwe