| Re: [hatari-devel] Re: Hatari SCSI Driver patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Re: Hatari SCSI Driver patch
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Wed, 28 Oct 2015 23:48:08 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1446072489; l=2369; s=domk; d=seimet.de; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Subject:To:From:Date; bh=u2/l9A1TILW05yqoQtDFkhKFDsg4qz+BDWhsGjqb8Lw=; b=GOK/cHW3zyDJS/BCT3mT90OMYUlnPaS6+E38RnP44T7nVAnIPDf2WAGgN0Jj5xe2HjW gHiQhuGO4Jxh6lUdhCXVlHPhrILa46VITlP8LMS9OEoPXNV73vjTIpyZUuM5kNxLrGnY3 nf7WH7qTASTDMAyMty/mVymxqRuEgxyqfOo=
Hi,
- udev : found, enables NatFeats SCSI Driver media change detection
As mentioned in my previous email this is not really correct. Even
without udev media changes are detected. But if udev is running a
different mechanism is required.
I'm quite picky about this because in the Atari world there are already
too many users who think they know how media change handling works, but
in fact they do *not* know ...
Take care
Uwe
> Hi,
>
> Commited:
> http://hg.tuxfamily.org/mercurialroot/hatari/hatari/rev/9e11e20df838
>
> With correstions to:
> - include file name for CMake macro [1]
> - message about found optional deps
> - readme.txt
>
> - Eero
>
> [1] Remove CMakeCache.txt each time before testing CMake
> file changes.
>
> It seems that if CMake has once found something, changing
> the check to something that doesn't exist, doesn't change
> anything, CMake digs the old path from cache.
>
> keskiviikko 28 lokakuu 2015 08:39:55 Uwe Seimet kirjoitti:
> > Hi,
> >
> > Should be better now, please see attachment.
> >
> > Take care
> >
> > Uwe
> >
> > > Hi,
> > >
> > > torstai 22 lokakuu 2015 12:31:18 Uwe Seimet kirjoitti:
> > > > The attached diffs add libudev support to the SCSI Driver, on systems
> > > > where libudev is available.
> > >
> > > I think that your CMake stuff has the issue that it checks udev header
> > > and library separately, but doesn't check that both are present.
> > > Both are needed to get a working binary.
> > >
> > > (If header is missing, linking udev is redundant. If library
> > > is missing, compiling stuff with udev header fails to linking
> > > error.)
> > >
> > > Besides note in readme.txt about libudev, IMHO note about
> > > it should be output at the end of the CMakeLists.txt file,
> > > like is done with the other libraries.
> > >
> > > Could you send an updated version?
> > >
> > > - Eero
> > >
> > > PS. Nicolas, SCSI drv adds only couple of KB to Hatari
> > > size even with libudev support:
> > > --------------
> > > $ size src/CMakeFiles/hatari.dir/nf_scsidrv.c.o
> > >
> > > text data bss dec hex filename
> > > 4918 0 640 5558 15b6
> > >
> > > src/CMakeFiles/hatari.dir/nf_scsidrv.c.o
> > > --------------
> > >
> > > (Real executable size increase can be less than
> > > the object file code/data/bss size.)
>
>
>