Re: [hatari-devel] Re: Hatari SCSI Driver patch

[ Thread Index | Date Index | More Archives ]

Le 28/10/2015 23:26, Uwe Seimet a écrit :

Hmm, I don't think that this would be correct. The SCSI Driver does not
require libudev. Only in case libudev is present in order to reliably detect
media changes the SCSI Driver has to be linked against it, and the
conditional code has to be compiled.
In other words, if HAVE_UDEV is 0 and the platform is Linux, the SCSI
Driver should be compiled without udev support. Only if the platform is
not Linux the driver shall not be compiled at all.

Please correct me if I am missing something.

OK, it's just me, I didn't read the whole source :)

Then maybe create a HAVE_SCSI_DRIVER in cmake if cmake detects the OS is linux, and remove the __linux__

The idea is to centralize all OS specific variables in one place (cmake) and then have only HAVE_xxx variables used in sources.

It will be much easier to extend Hatari to other OS this way (for example, maybe BSD can be built with nf_scsi driver, but it might not define __linux__ ?)


Mail converted by MHonArc 2.6.19+