| Re: [hatari-devel] Re: Hatari SCSI Driver patch |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Re: Hatari SCSI Driver patch
- From: Uwe Seimet <Uwe.Seimet@xxxxxxxxx>
- Date: Wed, 28 Oct 2015 23:26:58 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1446071219; l=892; s=domk; d=seimet.de; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Subject:To:From:Date; bh=VindZf0aeQrKiFq8QlzUgcAC9roPEJqfk3D2Lur2zxg=; b=Lax0U6kk+iAPic7Oh9CM1Q75yRS9MmdXTACTtqH2I5KAgbah0SiU7MJwulDg/0+oSdI FWxer6N7QEnBI5BxlSHguEshlsn6hcBOtmX2VI0NU2x3z66AHZk1lWsvLRG2xTy9724ZF ytx9eWI6q2T0ascscOULN6JuJe/EtBLUxag=
Hi,
Hmm, I don't think that this would be correct. The SCSI Driver does not
require libudev. Only in case libudev is present in order to reliably detect
media changes the SCSI Driver has to be linked against it, and the
conditional code has to be compiled.
In other words, if HAVE_UDEV is 0 and the platform is Linux, the SCSI
Driver should be compiled without udev support. Only if the platform is
not Linux the driver shall not be compiled at all.
Please correct me if I am missing something.
Take care
Uwe
> Le 28/10/2015 08:39, Uwe Seimet a écrit :
> > Hi,
> >
> > Should be better now, please see attachment.
> >
>
> Hi
>
> just a small note : since you define HAVE_UDEV to check if udev is
> available, I think you could remove the "#if defined(__linux__)" (in
> reset.c for example) and keep only the HAVE_xxxx coming from cmake
>
> Nicolas
>
>
>