Re: x color conversion [Was: Re: [AD] minor fix]

["Henrik Stokseth" <hensto@xxxxxxxxxx>]

"Elias Pschernig" <elias@xxxxxxxxxx> wrote:

> Ok, it's definitely the color conversion patch. See the attached
> testcase - it works when reverting the patch, and has random colors with
> it.

The testcase works fine here. Both in autodetect (!) as you've used in your
testcase, and in x11 windowed mode. As do all examples and the test program.
Have not tested the demo though, but IIRC the intro screen hacks the
graphics logo to change its colors and therefore could malfunction under X,
I suspect that it is this who triggered the problem, can you check?

Allegro screen visuals can use nonstandard bitshifts. As far as I can tell
this is ALWAYS the case under X. (BGR as opposed to RGB, native endianness)
To use the generic color converters in X, the patch has to tell Allegro what
bitshifts to use and in the case of 8bit switch R,G & B in the color
conversion palette. If and when you reply please attach the following
information:
- output from allegro debug trace log (allegro.log) from a program that
malfunctions.
- output from xdpyinfo

I also take the opportunity to remove some unreachable/dead code.
supplemental patch posted to sourceforge tracker.


Sincerely,
Henrik Stokseth.