Re: [hatari-devel] CPU dialog option fine-tuning (was: Falcon tests)

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 12.6.2022 23.46, Nicolas Pomarède wrote:
> > Yes definitely better, but I think there's enough space for more 
> > accurate explanation.
> >
> > Nicolas, what you would think of:
> > ----------------------------------
> > CPU emulation parameters
> >
> > [x] prefetch emulation (uses more host CPU)
> > [x] cycle-exact / cache emulation (can use much more host CPU)
> > [x] MMU emulation
> > [x] 24-bit addressing
> > [x] accurate FPU emulation (uses more host CPU)
> > ----------------------------------
>
> sounds fine to me, "slower" like it was before could indeed be misleading.

It did not quite fit as above.

Attached is patch, and a screenshot comparing the result with how the 
current GUI looks like.

I also changed the keyboard shortcuts a bit, so
that they're on first letter which IMHO is more
intuitive (and in case of "None", conforms with
System dialog).

Does that still look OK?


	- Eero

From 0e5e13fdae8c75b9d80b655e53a42b11696699e6 Mon Sep 17 00:00:00 2001
From: Eero Tamminen <oak@xxxxxxxxxxxxxx>
Date: Wed, 15 Jun 2022 22:41:53 +0300
Subject: [PATCH] Fine-tune SDL GUI CPU dialog texts and keyboard shortcuts

Be more explicit that options increase *host* CPU usage, to avoid
users thinking them making emulated system slower instead of faster.

Longer texts required increasing dialog width.  To keep dialog
balanced, radiobutton boxes needed to be moved.

Changed also keyboard shortcuts to be on first letters of (first)
words when possible.
---
 doc/release-notes.txt |  1 +
 src/gui-sdl/dlgCpu.c  | 68 +++++++++++++++++++++----------------------
 2 files changed, 35 insertions(+), 34 deletions(-)

diff --git a/doc/release-notes.txt b/doc/release-notes.txt
index 7e3e2248..cb629a9d 100644
--- a/doc/release-notes.txt
+++ b/doc/release-notes.txt
@@ -100,6 +100,7 @@ Emulator improvements:
   - Fix: avoid key release event from SDL GUI closing leaking to emulation
   - Do VDI mode size changes in (faster) 16 pix increments,
     and prevent user seeing invalid VDI mode sizes
+  - Fine-tune CPU dialog texts and keyboard shortcuts
 - GEMDOS HD:
   - Fix: clear GEMDOS Fread / Fwrite errors
   - Fix: Allow GEMDOS tasks to use other tasks' file handles
diff --git a/src/gui-sdl/dlgCpu.c b/src/gui-sdl/dlgCpu.c
index ca3777ea..7b49f382 100644
--- a/src/gui-sdl/dlgCpu.c
+++ b/src/gui-sdl/dlgCpu.c
@@ -34,40 +34,40 @@ const char DlgCpu_fileid[] = "Hatari dlgCpu.c";
 
 static SGOBJ cpudlg[] =
 {
-	{ SGBOX, 0, 0, 0,0, 46,24, NULL },
-	{ SGTEXT, 0, 0, 17,1, 14,1, "CPU options" },
-
-	{ SGBOX, 0, 0, 2,3, 13,9, NULL },
-	{ SGTEXT, 0, 0, 3,3, 8,1, "CPU type" },
-	{ SGRADIOBUT, 0, 0, 3, 5, 7,1, "680_00" },
-	{ SGRADIOBUT, 0, 0, 3, 6, 7,1, "680_10" },
-	{ SGRADIOBUT, 0, 0, 3, 7, 7,1, "680_20" },
-	{ SGRADIOBUT, 0, 0, 3, 8, 7,1, "680_30" },
-	{ SGRADIOBUT, 0, 0, 3, 9, 7,1, "680_40" },
-	{ SGRADIOBUT, 0, 0, 3,10, 7,1, "68060" },
-
-	{ SGBOX, 0, 0, 16,3, 13,9, NULL },
-	{ SGTEXT, 0, 0, 17,3, 15,1, "CPU clock" },
-	{ SGRADIOBUT, 0, 0, 17,5, 8,1, " _8 Mhz" },
-	{ SGRADIOBUT, 0, 0, 17,6, 8,1, "1_6 Mhz" },
-	{ SGRADIOBUT, 0, 0, 17,7, 8,1, "32 _Mhz" },
-
-	{ SGBOX, 0, 0, 30,3, 14,9, NULL },
-	{ SGTEXT, 0, 0, 31,3, 11,1, "FPU" },
-	{ SGRADIOBUT, 0, 0, 31,5, 6,1, "N_one" },
-	{ SGRADIOBUT, 0, 0, 31,6, 7,1, "68881" },
-	{ SGRADIOBUT, 0, 0, 31,7, 7,1, "68882" },
-	{ SGRADIOBUT, 0, 0, 31,8, 10,1, "_internal" },
-
-	{ SGBOX, 0, 0, 2,13, 42,8, NULL },
-	{ SGTEXT, 0, 0, 3,13, 11,1, "CPU parameters" },
-	{ SGCHECKBOX, 0, 0, 3,15, 23,1, "Prefetc_h mode, slower" },
-	{ SGCHECKBOX, 0, 0, 3,16, 21,1, "Cycle e_xact, slower" },
-	{ SGCHECKBOX, 0, 0, 3,17, 15,1, "MM_U emulation" },
-	{ SGCHECKBOX, 0, 0, 3,18, 20,1, "24 bits add_ressing" },
-	{ SGCHECKBOX, 0, 0, 3,19, 38,1, "Full software FPU emulation(softfloat)" },
-
-	{ SGBUTTON, SG_DEFAULT, 0, 13,22, 19,1, "Back to main menu" },
+	{ SGBOX, 0, 0, 0,0, 48,24, NULL },
+	{ SGTEXT, 0, 0, 18,1, 12,1, "CPU options" },
+
+	{ SGBOX, 0, 0, 2,3, 14,9, NULL },
+	{ SGTEXT, 0, 0, 4,3, 8,1, "CPU type" },
+	{ SGRADIOBUT, 0, 0, 4, 5, 7,1, "680_00" },
+	{ SGRADIOBUT, 0, 0, 4, 6, 7,1, "680_10" },
+	{ SGRADIOBUT, 0, 0, 4, 7, 7,1, "680_20" },
+	{ SGRADIOBUT, 0, 0, 4, 8, 7,1, "680_30" },
+	{ SGRADIOBUT, 0, 0, 4, 9, 7,1, "680_40" },
+	{ SGRADIOBUT, 0, 0, 4,10, 7,1, "68060" },
+
+	{ SGBOX, 0, 0, 17,3, 14,9, NULL },
+	{ SGTEXT, 0, 0, 19,3, 9,1, "CPU clock" },
+	{ SGRADIOBUT, 0, 0, 19,5, 8,1, " _8 Mhz" },
+	{ SGRADIOBUT, 0, 0, 19,6, 8,1, "1_6 Mhz" },
+	{ SGRADIOBUT, 0, 0, 19,7, 8,1, "32 Mh_z" },
+
+	{ SGBOX, 0, 0, 32,3, 14,9, NULL },
+	{ SGTEXT, 0, 0, 34,3, 11,1, "FPU" },
+	{ SGRADIOBUT, 0, 0, 34,5, 6,1, "_None" },
+	{ SGRADIOBUT, 0, 0, 34,6, 7,1, "68881" },
+	{ SGRADIOBUT, 0, 0, 34,7, 7,1, "68882" },
+	{ SGRADIOBUT, 0, 0, 34,8, 10,1, "_Internal" },
+
+	{ SGBOX, 0, 0, 2,13, 44,8, NULL },
+	{ SGTEXT, 0, 0, 3,13, 11,1, "CPU emulation parameters" },
+	{ SGCHECKBOX, 0, 0, 3,15, 23,1, "_Prefetch emulation (uses more host CPU)" },
+	{ SGCHECKBOX, 0, 0, 3,16, 21,1, "_Cache emulation / cycle exact (ditto)" },
+	{ SGCHECKBOX, 0, 0, 3,17, 15,1, "_MMU emulation" },
+	{ SGCHECKBOX, 0, 0, 3,18, 20,1, "24 _bits addressing" },
+	{ SGCHECKBOX, 0, 0, 3,19, 38,1, "Accurate _FPU emulation (no host FPU use)" },
+
+	{ SGBUTTON, SG_DEFAULT, 0, 14,22, 19,1, "Back to main menu" },
 	{ SGSTOP, 0, 0, 0,0, 0,0, NULL }
 };
 
-- 
2.30.2

Attachment: dialogs.png
Description: PNG image