| Re: [hatari-devel] Git commits |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] Git commits
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sat, 19 Mar 2022 19:38:00 +0000
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1647718702; bh=Nx6BE4oK0j6ap9RMh9+l9srPJaOdZZ36ijVfzf9Kz3A=; h=Date:From:To:Subject:From; b=oDxXAAp7E1ngjEi2WS4ec+R3E4WWiykrjl7KnaBp/D5VcgF3PqYMZaGIhvQPZ7mz6 HES2BhgNnGypcqQIwlbf6D0MffKa017PxPDjVIcTIF68bEHjZoDcN2R7Nj50CSh3Q2 qCKXWlm/yRCfjWuAqjaJu67T8+WL+l+7j1I0Li54zqva/DAX74liaX34U8+evi0W9R kv7ldZrf+rkyxcmBHlSph/4CkOclP7A1UlmYBlon01h/IyCfrf8PQ9qKLuDEUhqOJg /TNKln7Cd5Btrd8+Ada82zoQpkZi/ZBgLtKAyBEoLnoqQnOejBzmPHRyxpPjOJxGp7 CPMNUDQSWZSFw==
Am Mon, 14 Mar 2022 21:53:37 +0100
schrieb Uwe Seimet <Uwe.Seimet@xxxxxxxxx>:
> Hi,
>
> > Sorry, but I think you're confusing something. The statistic you posted
> > above refers to the length of the *summary* line [1], i.e., the first
> > line of the commit message.
>
> Yes, you are right. I was not aware of the distinction between the summary
> line and the body. I usually place the details in the PR, and keep the PR
> (initially a draft) up to date. github automatically adds a reference to
> the respective PR to the final commit message, so that you have the full
> context, including any discussions in the PR. Of course, anything that is in
> the PR is not available in your local repository, because the commit message
> just contains the PR ID. So there is a dependency on github if you want to
> know the whole story.
Now that's IMHO quite bad. If you ever want to move your repository to
another provider, you're losing precious information of the history. Thus
everything related to the description of a commit should ultimately go into
the commit description, not (only) into the PR description.
Thomas