Re: [hatari-devel] SCC support

[ Thread Index | Date Index | More lists.tuxfamily.org/hatari-devel Archives ]


Le 21/05/2021 à 12:30, Thomas Huth a écrit :

I agree with Nicolas, let's keep away from autogenerating them / adding more dependencies on external tools.

So if we want to re-order the defines, too, maybe it's best to go through an intermediate step with an enum instead, i.e.:

enum {
     ...
     TRACE_VIDEO_SYNC_BIT,
     TRACE_VIDEO_RES_BIT,
     TRACE_VIDEO_COLOR_BIT,
     ...
};

and then:

#define    TRACE_VIDEO_SYNC     (1 << TRACE_VIDEO_SYNC_BIT)
#define    TRACE_VIDEO_RES      (1 << TRACE_VIDEO_RES_BIT)
#define    TRACE_VIDEO_COLOR     (1 << TRACE_VIDEO_COLOR_BIT)
etc.

What do you think?

Hi

why not ; this creates an intermediate enum that we might not use for anything else, but it will create the correct TRACE_xxx flags

Nicolas




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/