Re: [hatari-devel] SCC support

[ Thread Index | Date Index | More Archives ]

This is a multi-part message in MIME format.

On 18.5.2021 22.57, Thomas Huth wrote:
Am Tue, 18 May 2021 00:55:27 +0300
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
Debug macros were a mix of different things, so I
converted them to SCC trace and DEBUG & WARN level
log outputs.

I also removed Init()/UnInit() debug output and
added output to reset functions (and removed superfluous "inline"
from one static function).

Does the mapping in the attached patch look reasonable enough to push?

Yes, looks fine to me at a first glance.

(Only testing I did for it was EmuTOS boot on TT
& Linux boot on Falcon.)

Thanks, I've pushed that commit.

Btw. There's also another, preliminary patch
that sorts trace options for trace help output.

Any objections on that?

Should the #defines in log.h get sorted accordingly?

I thought about that, but then the values would
need to be changed accordingly, *every* time one
adds new trace define.

Generating the trace mask values solves that, but
I couldn't get it work as well with CMake as I would have liked, and currently requires AWK
(so for Windows, the generated file probably
needs to be in git too).

See attached patch.   Comments?

(One difference to user visible names is that
defines have OS_ prefix for OS call trace options
so they get all sorted together, unlike the user
visible names which don't have a prefix...)

	- Eero

Mail converted by MHonArc 2.6.19+