Re: cmake versioning issue (was: Re: [hatari-devel] readline ?) |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx
- Subject: Re: cmake versioning issue (was: Re: [hatari-devel] readline ?)
- From: Thomas Huth <th.huth@xxxxxxxxx>
- Date: Sun, 13 Dec 2020 08:59:25 +0100
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1607846368; bh=5BRSB3xmyofbMqnUQJ/jnjhiLxerHKE4L3CRKJIICsQ=; h=Date:From:To:Subject:From; b=aEBYkk3p7M7F/tN5O1u6bw3PtjeTXtAhBDA4vwBm2oGmWF6K3j5Mp1MW8HTz0QLRk EsdVzEszvV4xTUYO6GLxhky6pAefGdhXpniNE20rFLnvE0xsFESAjTmNDAQFmif+Z7 bAz/0aXAsWqJXj5+YDGPjSB7APAFc7P9NPMG2R5YTgiOorJZNNs+795tvI5pRL6Rs1 Jf5hT5w3qqntAMpw52U5NVsfqazeywADsx9Okeh9gj725eNuOyydyPPwdcncj6Kubo JDxP38PnR48uAKXnF+c5RG0WTxF1jwY+GMRz67c8diiunf7hWXDfJ0lEF5U+DY/Qi0 OtWFztfL3SPZg==
Am Sun, 13 Dec 2020 02:07:09 +0200
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
[...]
> > If I run into more issues, I'll update my distro. But you really
> > ought to change readme.txt, it's wrong.
>
> Will do, once I know I know what's needed.
> Minimum required CMake version being
> 2.8 < x <= 3.13 is too vague. :-/
Looking through the CMake changes a little bit, I think the commit that
introduced the new behavior (between Something_FOUND and
SOMETHING_FOUND) was the following one here:
https://gitlab.kitware.com/cmake/cmake/-/commit/d1a6d15bcd4df3d3e3
That was released with CMake v3.3.
So I think we should either:
a) Bump our minimum required CMake version to 3.3
b) Try to work-around by renaming FindReadline.cmake to
FindREADLINE.cmake etc. and reverting commit 13dc63566ab73541d24e
I tend to option a), since it's less effort, CMake 3.3 has been
released since 5 years already, so it should be well-established
already and since there might be other issues lurking around in those
very old versions of CMake which we are not aware of yet.
Other opinions?
Thomas