| Re: [hatari-devel] Open Hatari in big window |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
This is a multi-part message in MIME format.
Hi,
On 3/6/20 8:03 AM, Thomas Huth wrote:
Am Fri, 6 Mar 2020 01:17:17 +0200
schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>> See the attached patch.
>
> Sorry, I currently do not have any spare time anymore to review patches
> (I'll be travelling during the next weeks)... so if somebody else could
> review this, that would be great.
Oh, that's unfortunate. I don't think Nicolas or
Laurent have looked at that part of the GUI code
much, and you did the SDL2 port.
If you could at some point during traveling take
a quick look at the "Support floating point zoom factors with SDL2"
patch "screen.c" changes, that
would be much appreciated.
No, just adding a command line option for just one release does not
make much sense. It's likely better to always do it automatically and
then to also remove the "linear scaling" option from the GUI.
Attached patch series has patch for removing
RenderScaleQuality config option, and replacing
"Linear scaling" option for it in GUI with "GPU
scaling" option to control bUseSdlRenderer option.
I did the GUI change like that mainly to avoid
breaking the Mac GUI code (I changed relevant
variable and button names there).
Please check with Nicolas whether he still wants that before or rather
after the next release.
Nicolas, any comments on this, and how's your
schedule for next release looking currently?
If next release is still 1-2 months away,
I'd like to get the change in, and get some
feedback for it.
maybe another thing to clean up after the next release...
Sounds like a plan, should I add these to deprecation list?
Yes, please!
In the last patch.
- Eero