Re: [hatari-devel] MEMWATCH freezes Hatari

[Uwe Seimet <Uwe.Seimet@xxxxxxxxx>]

Hi,

First of all, I sometimes get messages like this:

/home/us/hatari/hatari/src/cpu/cpuemu_0.c:15856:53: runtime error: left shift of 65535 by 16 places cannot be represented in type 'int'
/home/us/hatari/hatari/src/cpu/newcpu_common.c:402:7: runtime error: left shift of negative value -60
/home/us/hatari/hatari/src/cpu/cpuemu_0.c:32322:22: runtime error: signed integer overflow: 1658716160 + 1658716160 cannot be represented in type 'int'
/home/us/hatari/hatari/src/cpu/cpuemu_0.c:26895:22: runtime error: signed integer overflow: 1911522030 - -913332782 cannot be represented in type 'int'
/home/us/hatari/hatari/src/cycles.c:80:21: runtime error: signed integer overflow: 2147483180 + 752 cannot be represented in type 'int'

When starting ROMSPEED I get this before the double bus fault:

/home/us/hatari/hatari/src/cpu/newcpu.c:3460:14: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'

With MEMWATCH there is no change, the screen is cleared when starting
any program after it, and then the systems hangs.

With FIX24 I get:

/home/us/hatari/hatari/src/cpu/maccess.h:59:16: runtime error: store to misaligned address 0x5563b5929f8a for type 'uae_u32', which requires 4 byte alignment
0x5563b5929f8a: note: pointer points here
 13 2e  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00
              ^
/home/us/hatari/hatari/src/cpu/maccess.h:43:9: runtime error: load of misaligned address 0x5563b5929f8a for type 'uae_u32', which requires 4 byte alignment
0x5563b5929f8a: note: pointer points here
 13 2e  00 00 12 98 34 76 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00 00 00  00 00 00 00 00 00

Best regards

Uwe

> Le 11/10/2018 à 12:34, Uwe Seimet a écrit :
> > Now there are error messages when starting Hatari, and then it aborts,
> > see attached logs.
> 
> Indeed, there's a read outside of an array that must be fixed (I will 
> commit it later to main sources)
> 
> Please, change line 596 in video.c to this :
> 
> SHIFTER_LINE    ShifterLines[ MAX_SCANLINES_PER_FRAME+1 ];
> 
>  From there, hatari should run with only some errors about negative 
> values being left shifted : this is harmless and works as intended, I 
> think sanitize is too strict here.
> 
> When compiling with -fsanitize, I can for example run memwatch.prg or 
> fix24.prg and I don't get any abort from sanitizer.
> 
> Does it reports anything when you get bombs on screen ?
> 
> Nicolas
> 
>