| Re: [eigen] Why do we overwrite CMAKE_BUILD_TYPE ? |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Why do we overwrite CMAKE_BUILD_TYPE ?
- From: Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>
- Date: Mon, 25 Oct 2010 18:50:03 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=EC5NHxmKx28l7A4zB/wWjxmoK4s9q+cjoiLKRSoeDRM=; b=tAhT9EJ+1kLUbAtSRu20pR8IsxPCg9OjX5ICo4lQ+BkYKYX6+P37OyQgcDEkuFoH7t Gb8c56oN6OSzsfYO7PxuvIiZo+l/XwzMYrXqljy+6pKcyFX9dGfiLhW3JTjgfeK5eo7p 0CKz//w8BAjFXY/Pe684zDy0ak+8nZeIIYWoQ=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=HAIEDLWSfRGFjP+I5WB3DylV5Z/BO2no3y4fSLO6HxxvsOatjB+2jTIQTOmbxoAe8D M2AMurwaHH3ubQIlSOvz7WSbeTmAR/6ibc1UFM43Z+P7x2mSdPHUevcQIirX3URiHXuu OAL/JcZzgmBX8Or99JXcCXf/r4EBieTWRfHYQ=
The new fix is still problematic.
I pushed yet another version since ${CMAKE_BUILD_TYPE} does not
necessarily need to be set at all. I am just double checking for that
option. In this particular case, ${CMAKE_BUILD_TYPE} will be set to
"Debug;Release;MinSizeRel;RelWithDebInfo" and this setting is required
for IDEs in which you can switch at will between these configuration.
- Hauke
On Sat, Oct 23, 2010 at 4:02 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> Actually, I just checked and the CMake build type seems to be
> case-insensitive anyway. So I just removed that code.
>
> Benoit
>
> 2010/10/21 Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>:
>> it's worth a one-line comment, then, no ? ;)
>>
>> Thomas
>>
>> --
>>
>> Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
>>
>> http://www.freehackers.org/thomas
>>
>> On Thursday 21 October 2010 14:31:56 Benoit Jacob wrote:
>>
>>> 2010/10/21 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
>>
>>> > We have these lines in our CMakeLists.txt
>>
>>> >
>>
>>> > string(TOLOWER "${CMAKE_BUILD_TYPE}" cmake_build_type_tolower)
>>
>>> > if(cmake_build_type_tolower STREQUAL "debug")
>>
>>> > set(CMAKE_BUILD_TYPE "Debug")
>>
>>> > else()
>>
>>> > set(CMAKE_BUILD_TYPE "Release")
>>
>>> > endif()
>>
>>> >
>>
>>> > IMHO we can safely remove this code.
>>
>>>
>>
>>> I was scared that a case typo in the build type would silently fail.
>>
>>> I'll make sure it doesn't change anything but the case.
>>
>>>
>>
>>> Benoit
>>
>>>
>>
>>>
>>
>>> >
>>
>>> > - Hauke
>>
>>> >
>>
>>> >
>>
>>> >
>>
>>>
>>
>>>
>>
>>>
>
>
>