| Re: [eigen] Why do we overwrite CMAKE_BUILD_TYPE ? |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Why do we overwrite CMAKE_BUILD_TYPE ?
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Thu, 21 Oct 2010 08:31:56 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=jHfHhSkbvUSrS69wwdwkpDvOtiD/tWfdRyt2E9HXjZM=; b=tENQRqGUVWmDLhQuy54+vpC0Lem54dnFb7mEmsRjHHrygxH2fudDA44LLCaRso8kcn hSe7GKfM/Jpx7wa+IPYxTPXZH37SH4K1LL87RpCDku+F87k/hhdWAP2XkFbFtjRmUUP6 xzfdprRZF86qtqIp3KG7Swgv7LaFkCgu+gYj0=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=NY28sUSnYJcVMBWGCKyyI6zpvBojcnOJ1mwUbbidbKemFCVboXPPBGMmHm2tbuXRps WABbG/NpQRRZKpk1K4JDA2TycolxrQZSJHEjbUtnA9qO2dlQi6iVz8gW8qeHEL7Y2gp3 NgkhVJYy9Pr0mDNfxf4+sPxngb1L+BHCYjmwY=
2010/10/21 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
> We have these lines in our CMakeLists.txt
>
> string(TOLOWER "${CMAKE_BUILD_TYPE}" cmake_build_type_tolower)
> if(cmake_build_type_tolower STREQUAL "debug")
> set(CMAKE_BUILD_TYPE "Debug")
> else()
> set(CMAKE_BUILD_TYPE "Release")
> endif()
>
> IMHO we can safely remove this code.
I was scared that a case typo in the build type would silently fail.
I'll make sure it doesn't change anything but the case.
Benoit
>
> - Hauke
>
>
>