| Re: [eigen] Why do we overwrite CMAKE_BUILD_TYPE ? |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Why do we overwrite CMAKE_BUILD_TYPE ?
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Sat, 23 Oct 2010 10:02:28 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=2c44K5Bmlyxk+76b53CdbqcIBCDMuWc2iPUa2Sb3Ty4=; b=xktpkiyFG9LPIEsSJ49CG4Z3HQDDm5jgN4/kN/jJVfOJYN5+6Kie1c84JArXujW/Al uNSci1R7QUeSflGQxIZNd6YjWcwQBGAWrGxtK5R502Sj5HUed4dnuuyzfUICXLeiZjx+ 96cDX5achyHayPIXLwqP/6ckuZCBFEpX5XGno=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=vbXOxjLin4B4B0mYIed6Kdi3had9oYL99TZswlo6wprK/5N0myNIwY5P7OQMmm74X7 z128zdzII7tqDexP2BePdZmwmFleRgK9cIODz5qKI4XM1vgCky2bkl74rnXdJOFvd2r8 fQp8+M9ONWTAyDGXAJXILR8EcgV7+KZKVw5rs=
Actually, I just checked and the CMake build type seems to be
case-insensitive anyway. So I just removed that code.
Benoit
2010/10/21 Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>:
> it's worth a one-line comment, then, no ? ;)
>
> Thomas
>
> --
>
> Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>
>
> http://www.freehackers.org/thomas
>
> On Thursday 21 October 2010 14:31:56 Benoit Jacob wrote:
>
>> 2010/10/21 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
>
>> > We have these lines in our CMakeLists.txt
>
>> >
>
>> > string(TOLOWER "${CMAKE_BUILD_TYPE}" cmake_build_type_tolower)
>
>> > if(cmake_build_type_tolower STREQUAL "debug")
>
>> > set(CMAKE_BUILD_TYPE "Debug")
>
>> > else()
>
>> > set(CMAKE_BUILD_TYPE "Release")
>
>> > endif()
>
>> >
>
>> > IMHO we can safely remove this code.
>
>>
>
>> I was scared that a case typo in the build type would silently fail.
>
>> I'll make sure it doesn't change anything but the case.
>
>>
>
>> Benoit
>
>>
>
>>
>
>> >
>
>> > - Hauke
>
>> >
>
>> >
>
>> >
>
>>
>
>>
>
>>