Re: [eigen] Why do we overwrite CMAKE_BUILD_TYPE ?

[Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>]

it's worth a one-line comment, then, no ? ;)

Thomas

--

Thomas Capricelli <orzel@xxxxxxxxxxxxxxx>

http://www.freehackers.org/thomas

On Thursday 21 October 2010 14:31:56 Benoit Jacob wrote:

> 2010/10/21 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:

> > We have these lines in our CMakeLists.txt

> >

> > string(TOLOWER "${CMAKE_BUILD_TYPE}" cmake_build_type_tolower)

> > if(cmake_build_type_tolower STREQUAL "debug")

> >  set(CMAKE_BUILD_TYPE "Debug")

> > else()

> >  set(CMAKE_BUILD_TYPE "Release")

> > endif()

> >

> > IMHO we can safely remove this code.

>

> I was scared that a case typo in the build type would silently fail.

> I'll make sure it doesn't change anything but the case.

>

> Benoit

>

>

> >

> > - Hauke

> >

> >

> >

>

>

>