Re: [eigen] sse asin implementation |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] sse asin implementation
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Tue, 31 Mar 2009 17:53:19 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=/NAz5TXjVjZBsDVhF1PLsozNLWM4eXgUw5N7q2yV8zU=; b=rk82I6uaNYJrDqIVp0J/e43uEiNUhehpQr3v2J3JAIDgi9W9XBY+yrERkNJu/GYcMI Ukjk6jV6fX7n7bLfqkimGzEzvAJim04zJfj1EuBBEUd4wvdG2kxQZqcGw5y8r98tsTgX BUR4wcJiKorepyw+sPnW3ro/ay5PSfVb+HMxs=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=VLEgj5GiAY1AXL40D9mgYup+svXZcYryuXwqiFMdDwlokcMFm98Rb0YQkkHD8pi0ST +9R1ekHrLlDWGGL/Iir9Nr5lWCPCimHeaY0epYBFB1iK2wbz8agsXzanTK/UegzlKzsO rp6JHWAm32zfeTSEoKiggeAC3WDjxGdaHb4W4=
I am wary of working implementations that are not used: every line of
code incurs a maintainance burden. And Eigen can't try to do all
things mathematics, it is a linear algebra library, it's true that we
have some more stuff but that has always been dictated by the
existence of use cases.
Since Gael mentioned asin on the TODO, it's OK, just wait for him to
come back (he's away at the moment for a few days).
But for hyperbolic functions, i'm really really not sure there are
enough use cases!
As I said, there's at least one very useful function that's not yet
vectorized: pow.
Cheers,
Benoit
2009/3/31 Rohit Garg <rpg.314@xxxxxxxxx>:
>> Well if Gael added that function I guess he had a reason... and since
>> you coded it I guess it doesn't hurt to add it!
>>
>> I'll leave him handle your patch !
>
> I was thinking of vectorizing stuff like acos, atan, and hyperbolic
> stuff too. I must ask now if they are worth committing. IMHO, it's
> better to have a working implementation which may not be used instead
> of waiting for a a function's use case to appear.
>
> Cheers,
>
> --
> Rohit Garg
>
> http://rpg-314.blogspot.com/
>
> Senior Undergraduate
> Department of Physics
> Indian Institute of Technology
> Bombay
>
>
>