| Re: [eigen] sse asin implementation |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] sse asin implementation
- From: Rohit Garg <rpg.314@xxxxxxxxx>
- Date: Tue, 31 Mar 2009 11:25:41 +0530
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=gjkLebQBV5F7yqjI5paPPeCDmvbbfqPHkP1ebYbCm2U=; b=UXwnc+2JfiKGY0zxDs8f7UE0H+0TWg1y29i17+wvM9DvK/NQAENE8iQbS09XI2nEvo KAI3/Q4DW74p/fOeCreCONFqmpqbZiBSlVE2sjGP4YSCQFUk5kI+sO6IsoU3sWKQ3Jug iriyWwNT02LfQOnEQZaGnH+eBQjrIbtd7JMZ4=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=T0K4Nzz5f5iBZ5+Ctcr9drlSNjf6g/TsEPC8BQKAGxV6NQQQ5quxaIQIigDSfq6+vg MHRr7ZkJkRmuXvaCSPSIOfgW6HA+Xs6KkWLJnIcnebxoc3VZQVX3ZYMABlT9lNFHRhRi 9lPTR8LprXT00H9LL7aI6WzvlfIKG63SaJS6A=
will do that sure.
On Tue, Mar 31, 2009 at 12:52 AM, Schleimer, Ben <bensch128@xxxxxxxxx> wrote:
>
> Hi Rohit,
> It would be good if you added a unit test for this, (maybe along the lines of test/packetmath.cpp. maybe you can fit it into packetmath_real(), not sure though since you are working with sse)
>
> If you get the unittest up, running and stress testing your code, then you will be safe to check in IMHO.
>
> Cheers
> Ben
>
>
>
> --- On Mon, 3/30/09, Rohit Garg <rpg.314@xxxxxxxxx> wrote:
>
>> From: Rohit Garg <rpg.314@xxxxxxxxx>
>> Subject: [eigen] sse asin implementation
>> To: eigen@xxxxxxxxxxxxxxxxxxx
>> Date: Monday, March 30, 2009, 7:52 AM
>> This file has the patch for sse
>> implementation of asin. I have written
>> it along the lines of the cephes library. I have dropped
>> one branch
>> which cephes takes that for x<1e-4 asin(x) is the same
>> as x. Also I
>> don't know how to handle out of range inputs, so I dropped
>> the error
>> checking. Perhaps, the user should be more careful before
>> calling this
>> function. I dunno if it will return NaN for out of range
>> inputs. I
>> wrote this in the MathFunctions.h file using as much of
>> eigen's
>> abstraction so someone porting it to Altivec won't curse me
>> too much.
>> :)
>>
>> Also I noted that Gael while committing my input had to
>> write a fair
>> amount of top level code since I was writing pure intrinsic
>> functions.
>> So I cut some slack here and decided to write it as close
>> to eigen's
>> final implementation as I could. Unfortunately, it means
>> that since I
>> am not sure of what else do I need to patch, I couldn't
>> test it. :(
>> But it is a very simple one, so perhaps no errors made it
>> through. :)
>>
>> On a related note, perhaps we should have an ei_psel
>> function since it
>> is going to be used a lot (in transcendental functions
>> atleast) so
>> would help with porting to altivec.
>>
>> --
>> Rohit Garg
>>
>> http://rpg-314.blogspot.com/
>>
>> Senior Undergraduate
>> Department of Physics
>> Indian Institute of Technology
>> Bombay
>>
>
>
>
--
Rohit Garg
http://rpg-314.blogspot.com/
Senior Undergraduate
Department of Physics
Indian Institute of Technology
Bombay