Re: [AD] Old problems that still persist on Allegro 4.2 beta 3

[Evert Glebbeek <eglebbk@xxxxxxxxxx>]

> Hm, harder than I thought. The attached patch allowed me to do it,
> otherwise grabber and dat would choke on the same files for which 4.0.3
> grabber and dat work fine. Oh, and it's quite late, so in fact, I'm not
> very sure about the patch..

Some quick thoughts, I'll have a closer look later today.

-   num = end - begin+1;
+   num = end - begin;

This looks wrong. A font that has a range of 32-32 has one character in it,
a space. Beside which, the mono font code should also have a similar line
to that one that would also need to be fixed if this is an error (but It
think your patch is wrong here).

+      /* load_bitmap_font makes the font start with character 32, so f2 is
a
+       * wrong font, we can't use functions like extract_font_range on it.
+       * Instead, we transpose all characters so they have the correct
range
+       * again.
+       */

I don't understand. Please explain.
Also, the font loading code is not really different from the 4.0.3 font
loading code, except that it's now in the library rather than the grabber.
As far as I remember, fonts have always started at character 32. I
certainly don't think you want to transpose it (turning upper case
characters into lower case ones) before merging (in fact, you should *not*
want to do that unless there's a bug in how merge_fonts() is implemented).

Could you explain a bit more what your patch is supposed to solve? To me,
it looks more like it would introduce problems rather than fix any. :)

Evert