Re: [hatari-devel] Fixing some STE sound issue and doing 2.4.1 release

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 29.7.2022 11.57, Eero Tamminen wrote:
> On 29.7.2022 10.37, Nicolas Pomarède wrote:
> > Le 24/07/2022 à 14:35, Nicolas Pomarède a écrit :
> > > As this could really alter sound in a bad way, I'm considering  doing 
> > > a 2.4.1 release with this fix (and the other few commits that went in 
> > > since the release).
> > >
> > > Does anyone want to commit some other changes regarding some bugs 
> > > that could have been reported since hatari 2.4 was released ?
> >
> > So, docs and small code fixes were done during the previous days.
> > Is there any pending fix that should still go in or we can create 2.4.1 ?
>
> Nothing on my side, and there have been no new issues reported on 
> Atari-forum for 2.4.0, so looks good to go.
>
> To make sure the minor video an YM fixes did not cause any TOS bootup 
> regression, I'll run TOS tester and let you know later today how it went.

Run on original TOS version finished, but I got some fails in the 1928 
test-runs:
-----------------------------
  - tos205de-ste-mono-gemdos-10M-0M-cpuexacton: ['pass', 'FAIL', 
'FAIL', 'FAIL']
  - tos205de-megaste-vdi1-gemdos-4M-0M-cpuexactoff: ['pass', 'FAIL', 
'FAIL', 'FAIL']
  - tos205de-megaste-vdi1-gemdos-10M-0M-cpuexacton: ['pass', 'pass', 
'FAIL', 'FAIL']
  - tos205de-megaste-vdi1-gemdos-10M-0M-cpuexactoff: ['pass', 'pass', 
'pass', 'FAIL']
  - tos306uk-tt-vdi4-gemdos-0M-0M-cpuexactoff: ['pass', 'FAIL', 'FAIL', 
'FAIL']
  - tos404-falcon-rgb-floppy-0M-0M-cpuexactoff: ['pass', 'FAIL', 
'FAIL', 'FAIL']
-----------------------------

I'll check whether they are reproducible (i.e. real issue), but in the 
meanwhile I ran also Hatari's own tests under AddressSanitizer, and got 
failures also in those:
-----------------------------
The following tests FAILED:
	  4 - command-fifo (Failed)
	 47 - screen-end-st-color (Failed)
	 48 - screen-end-st-mono (Failed)
	 49 - screen-end-st-vdi (Failed)
	 50 - screen-end-ste-color (Failed)
	 51 - screen-end-ste-mono (Failed)
	 52 - screen-end-ste-vdi (Failed)
	 53 - screen-end-tt-color (Failed)
	 54 - screen-end-tt-mono (Failed)
	 55 - screen-end-tt-vdi (Failed)
	 56 - screen-end-falcon-color (Failed)
	 57 - screen-end-falcon-mono (Failed)
	 58 - screen-end-falcon-vdi (Failed)
	 78 - screen-fullscreen-st (Failed)
	 79 - screen-fullscreen-ste (Failed)
-----------------------------

Could you check the fullscreen and screen-end tests using  Hatari 
compiled with AddressSanitizer:
	cmake -D ENABLE_ASAN:BOOL=1 ..
?

I'll check what the AddressSanitizer complains about the FIFO test, and 
continue with TOS boot tester (check failing cases, and start running 
EmuTOS versions).


	- Eero