| Re: [hatari-devel] Fixing some STE sound issue and doing 2.4.1 release |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
Le 29/07/2022 à 15:27, Eero Tamminen a écrit :
Hi,
On 29.7.2022 11.57, Eero Tamminen wrote:
On 29.7.2022 10.37, Nicolas Pomarède wrote:
Le 24/07/2022 à 14:35, Nicolas Pomarède a écrit :
As this could really alter sound in a bad way, I'm considering
doing a 2.4.1 release with this fix (and the other few commits that
went in since the release).
Does anyone want to commit some other changes regarding some bugs
that could have been reported since hatari 2.4 was released ?
So, docs and small code fixes were done during the previous days.
Is there any pending fix that should still go in or we can create
2.4.1 ?
Nothing on my side, and there have been no new issues reported on
Atari-forum for 2.4.0, so looks good to go.
To make sure the minor video an YM fixes did not cause any TOS bootup
regression, I'll run TOS tester and let you know later today how it went.
Run on original TOS version finished, but I got some fails in the 1928
test-runs:
-----------------------------
- tos205de-ste-mono-gemdos-10M-0M-cpuexacton: ['pass', 'FAIL',
'FAIL', 'FAIL']
- tos205de-megaste-vdi1-gemdos-4M-0M-cpuexactoff: ['pass', 'FAIL',
'FAIL', 'FAIL']
- tos205de-megaste-vdi1-gemdos-10M-0M-cpuexacton: ['pass', 'pass',
'FAIL', 'FAIL']
- tos205de-megaste-vdi1-gemdos-10M-0M-cpuexactoff: ['pass', 'pass',
'pass', 'FAIL']
- tos306uk-tt-vdi4-gemdos-0M-0M-cpuexactoff: ['pass', 'FAIL', 'FAIL',
'FAIL']
- tos404-falcon-rgb-floppy-0M-0M-cpuexactoff: ['pass', 'FAIL',
'FAIL', 'FAIL']
-----------------------------
I'll check whether they are reproducible (i.e. real issue), but in the
meanwhile I ran also Hatari's own tests under AddressSanitizer, and got
failures also in those:
-----------------------------
The following tests FAILED:
4 - command-fifo (Failed)
47 - screen-end-st-color (Failed)
48 - screen-end-st-mono (Failed)
49 - screen-end-st-vdi (Failed)
50 - screen-end-ste-color (Failed)
51 - screen-end-ste-mono (Failed)
52 - screen-end-ste-vdi (Failed)
53 - screen-end-tt-color (Failed)
54 - screen-end-tt-mono (Failed)
55 - screen-end-tt-vdi (Failed)
56 - screen-end-falcon-color (Failed)
57 - screen-end-falcon-mono (Failed)
58 - screen-end-falcon-vdi (Failed)
78 - screen-fullscreen-st (Failed)
79 - screen-fullscreen-ste (Failed)
-----------------------------
Could you check the fullscreen and screen-end tests using Hatari
compiled with AddressSanitizer:
cmake -D ENABLE_ASAN:BOOL=1 ..
?
I'll check what the AddressSanitizer complains about the FIFO test, and
continue with TOS boot tester (check failing cases, and start running
EmuTOS versions).
I see you fixed the load config and png save code at the same time I did
:) not pushing my change in this case.
but tests are still failing for me (many more than in your cases). They
all report this :
Direct leak of 920 byte(s) in 5 object(s) allocated from:
#0 0x7f562d0b8757 in calloc (/lib64/libasan.so.8+0xb8757)
#1 0x7f562bacb4df
(/home/npomarede/src/hatari.git/src/hatari+0x78984df)
Direct leak of 520 byte(s) in 13 object(s) allocated from:
#0 0x7f562d0b8d6f in __interceptor_malloc (/lib64/libasan.so.8+0xb8d6f)
#1 0x7f562bae4593
(/home/npomarede/src/hatari.git/src/hatari+0x78b1593)
Direct leak of 96 byte(s) in 3 object(s) allocated from:
#0 0x7f562d0b8d6f in __interceptor_malloc (/lib64/libasan.so.8+0xb8d6f)
#1 0x7f562badbdce
(/home/npomarede/src/hatari.git/src/hatari+0x78a8dce)
Direct leak of 24 byte(s) in 1 object(s) allocated from:
#0 0x7f562d0b8d6f in __interceptor_malloc (/lib64/libasan.so.8+0xb8d6f)
#1 0x7f562badda91
(/home/npomarede/src/hatari.git/src/hatari+0x78aaa91)
Indirect leak of 1198 byte(s) in 7 object(s) allocated from:
#0 0x7f562d0b7c75 in __interceptor_realloc.part.0
(/lib64/libasan.so.8+0xb7c75)
#1 0x7f562badded4
(/home/npomarede/src/hatari.git/src/hatari+0x78aaed4)
Indirect leak of 120 byte(s) in 3 object(s) allocated from:
#0 0x7f562d0b8d6f in __interceptor_malloc (/lib64/libasan.so.8+0xb8d6f)
#1 0x7f562baddfa3
(/home/npomarede/src/hatari.git/src/hatari+0x78aafa3)
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
#0 0x7f562d0b8d6f in __interceptor_malloc (/lib64/libasan.so.8+0xb8d6f)
#1 0x7f562badda91
(/home/npomarede/src/hatari.git/src/hatari+0x78aaa91)
Indirect leak of 24 byte(s) in 1 object(s) allocated from:
#0 0x7f562d0b8d6f in __interceptor_malloc (/lib64/libasan.so.8+0xb8d6f)
#1 0x7f562baddae5
(/home/npomarede/src/hatari.git/src/hatari+0x78aaae5)
unfortunately, there's no indication of what part of th code it is.