Re: [hatari-devel] Fixing some STE sound issue and doing 2.4.1 release

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi,

On 29.7.2022 16.27, Eero Tamminen wrote:
> Run on original TOS version finished, but I got some fails in the 1928 
> test-runs:

I checked the saved outputs for these, but I was unable to replicate 
manually any of the issues, so I guess they can be ignored.

> -----------------------------
>    - tos205de-ste-mono-gemdos-10M-0M-cpuexacton: ['pass', 'FAIL', 
> 'FAIL', 'FAIL']

Bombed at boot (2 bombs).

>    - tos205de-megaste-vdi1-gemdos-4M-0M-cpuexactoff: ['pass', 'FAIL', 
> 'FAIL', 'FAIL']

Did not finish test (too slow?).

>    - tos205de-megaste-vdi1-gemdos-10M-0M-cpuexacton: ['pass', 'pass', 
> 'FAIL', 'FAIL']

Fwrite failed.

>    - tos205de-megaste-vdi1-gemdos-10M-0M-cpuexactoff: ['pass', 'pass', 
> 'pass', 'FAIL']

I do not see what was the problem here.

>    - tos306uk-tt-vdi4-gemdos-0M-0M-cpuexactoff: ['pass', 'FAIL', 'FAIL', 
> 'FAIL']
>    - tos404-falcon-rgb-floppy-0M-0M-cpuexactoff: ['pass', 'FAIL', 
> 'FAIL', 'FAIL']

These bombed (2 bombs) on boot, but 512k RAM is not really important 
use-case for TT & Falcon...

> -----------------------------

(For some reason AddressSanitizer crashes with above tests when Hatari 
exits.  Valgrind reports no issues.)


I'll run boot tests for EmuTOS (v1.1.1) variants next.


> meanwhile I ran also Hatari's own tests under AddressSanitizer, and got 
> failures also in those:
> -----------------------------
> The following tests FAILED:
>        4 - command-fifo (Failed)
>       47 - screen-end-st-color (Failed)
>       48 - screen-end-st-mono (Failed)
>       49 - screen-end-st-vdi (Failed)
>       50 - screen-end-ste-color (Failed)
>       51 - screen-end-ste-mono (Failed)
>       52 - screen-end-ste-vdi (Failed)
>       53 - screen-end-tt-color (Failed)
>       54 - screen-end-tt-mono (Failed)
>       55 - screen-end-tt-vdi (Failed)
>       56 - screen-end-falcon-color (Failed)
>       57 - screen-end-falcon-mono (Failed)
>       58 - screen-end-falcon-vdi (Failed)
>       78 - screen-fullscreen-st (Failed)
>       79 - screen-fullscreen-ste (Failed)
> -----------------------------

PNG save leak fix got most passing, but screen-end VDI tests trigger 
heap buffer overflow:
--------------------------------------------
tests/mem_end$ ./run_test.sh ../../build/src/hatari ./scr_end.prg 
--machine st --vdi on
Running hatari FAILED. Status=1. Hatari output:
Screen dump saved to: /tmp/tmp.A93LffwNx7/grab0001.png
=================================================================
==36481==ERROR: AddressSanitizer: heap-buffer-overflow on address 
0x7fe1930b7840 at pc 0x55c0e205bd87 bp 0x7fff1d4344a0 sp 0x7fff1d434498
READ of size 4 at 0x7fe1930b7840 thread T0
    #0 0x55c0e205bd86 in Screen_BitplaneToChunky32 src/screenConvert.c:205
    #1 0x55c0e205ef81 in ScreenConv_BitplaneLineTo32bpp 
src/screenConvert.c:342
    #2 0x55c0e205ef81 in ScreenConv_BitplaneTo32bppNoZoom 
src/screenConvert.c:453
    #3 0x55c0e205ef81 in Screen_ConvertWithoutZoom src/screenConvert.c:680
    #4 0x55c0e205ef81 in Screen_GenConvert src/screenConvert.c:1146
    #5 0x55c0e206267b in Screen_GenDraw src/screenConvert.c:1166
    #6 0x55c0e2085134 in Video_DrawScreen src/video.c:4399
    #7 0x55c0e2085134 in Video_InterruptHandler_VBL src/video.c:4577

0x7fe1930b7840 is located 0 bytes to the right of 4251712-byte region 
[0x7fe192ca9800,0x7fe1930b7840)
allocated by thread T0 here:
    #0 0x7fe198620037 in __interceptor_calloc 
.../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:154
    #1 0x55c0e218a845 in memory_init src/cpu/memory.c:1676
    #2 0x55c0e206fdc3 in TOS_InitImage src/tos.c:1135
    #3 0x55c0e2040462 in Reset_ST src/reset.c:61
    #4 0x55c0e1f7e2e2 in Main_Init src/main.c:757
    #5 0x55c0e1f7e2e2 in main src/main.c:951

SUMMARY: AddressSanitizer: heap-buffer-overflow src/screenConvert.c:205 
in Screen_BitplaneToChunky32
Shadow bytes around the buggy address:
  0x0ffcb260eeb0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0ffcb260eec0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0ffcb260eed0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0ffcb260eee0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
  0x0ffcb260eef0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
=>0x0ffcb260ef00: 00 00 00 00 00 00 00 00[fa]fa fa fa fa fa fa fa
  0x0ffcb260ef10: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffcb260ef20: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffcb260ef30: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffcb260ef40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x0ffcb260ef50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
--------------------------------------------


	- Eero