Re: [hatari-devel] Lockup demo

[Laurent Sallafranque <laurent.sallafranque@xxxxxxx>]

Hi,


I've comited a more simple version of the fix.

No need to add the "dsp_core.interrupt_state == DSP_INTERRUPT_NONE" when 
searching for a new interruption.

The patch is very easy now. I've just moved the 2 interruptions into the 
main interruption routine.

Before, the hostport interruption was tested only after a DSP or host 
read or write, but the interruption can happen as soon as the buffers 
are empty or full.

Now, I just do the test after each DSP instruction.


I've done many tests with demos that I know use DSP interrupts, games 
and music programs.

I didn't notice any regression with this patch.


Enjoy Lockup demo now ;)

Regards

Laurent



Le 05/12/2020 à 01:10, Eero Tamminen a écrit :
> Hi,
>
> On 12/4/20 10:56 PM, Nicolas Pomarède wrote:
> > Le 04/12/2020 à 21:51, Laurent Sallafranque a écrit :
> > > My version of the demo was corrupted (2 bombs).
> > >
> > > I've downloaded another one.
> > >
> > >
> > > I've fixed the DSP Host interrupts and now, I have the demo with the 
> > > tridi.
> > >
> > > It was present but had never been tested before.
> > >
> > > The demo runs super well ;)
> > >
> > >
> > > Still have to give a try to the timer now to have the music.
> > >
> > >
> > > Eero, can I comit my changes into the DSP interrupts ?
> >
> > can you send the corresponding patch here ?
>
> Nicolas, is it now OK to commit code changes to master?
>
> If there needs to be 2.3.1 release, I think it should be done from 
> separate bug fix branch forked from release notes typo commit 
> (cecfe23a1f), just
> before Laurent's DSP sound fix (as that wasn't
> regression from previous release, and fix is not
> yet tested with large enough amount of Falcon SW).
>
>
>     - Eero