Re: [hatari-devel] Lockup demo

[Laurent Sallafranque <laurent.sallafranque@xxxxxxx>]

I agree. And the fix really change a specific case: host interrupts are 
nearly never used ( I had never seen this before).

I don't know if there's another demo than lockup that use it.


Laurent


Le 05/12/2020 à 10:20, Nicolas Pomarède a écrit :
> Le 05/12/2020 à 01:10, Eero Tamminen a écrit :
> > Hi,
> >
> > On 12/4/20 10:56 PM, Nicolas Pomarède wrote:
> > > Le 04/12/2020 à 21:51, Laurent Sallafranque a écrit :
> > > > My version of the demo was corrupted (2 bombs).
> > > >
> > > > I've downloaded another one.
> > > >
> > > >
> > > > I've fixed the DSP Host interrupts and now, I have the demo with 
> > > > the tridi.
> > > >
> > > > It was present but had never been tested before.
> > > >
> > > > The demo runs super well ;)
> > > >
> > > >
> > > > Still have to give a try to the timer now to have the music.
> > > >
> > > >
> > > > Eero, can I comit my changes into the DSP interrupts ?
> > >
> > > can you send the corresponding patch here ?
> >
> > Nicolas, is it now OK to commit code changes to master?
> >
> > If there needs to be 2.3.1 release, I think it should be done from 
> > separate bug fix branch forked from release notes typo commit 
> > (cecfe23a1f), just
> > before Laurent's DSP sound fix (as that wasn't
> > regression from previous release, and fix is not
> > yet tested with large enough amount of Falcon SW).
>
> Hi
>
> I'm not that sure dsp fixes by laurent should go into another branch : 
> we have the issue with IDE+falcon and also the macOS UI issue where it 
> seems FPU is not correctly applied.
> Maybe it will take 1 o 2 weeks anyway to fix these 2.
>
> In the meantime, I think we can commit Laurent's changes and test them 
> with falcon's demos having sound issues to check if no regression 
> appears.
>
> If we see problem, then we rollback thoses DSP fixes and don't include 
> them in 2.3.1 ; if no regression then thoses fixes will be an extra 
> bonus in 2.3.1
>
> Nicolas