| Re: [eigen] still the solve() API debate |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] still the solve() API debate
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Mon, 14 Sep 2009 17:29:38 -0400
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=6hpnzdkO95AqGnfGt54aI60zSlzO7cEI5LkJD8U/HpM=; b=Z1X7Dqp0Rtd/CFxSMIYMtYWl4jDhSAAbIijTsQbsqF1apozh7itbutUm3ivGjFawyX +iaTtBRCWYBhi4IOyZV4D6ev2t4N7sRuOmvnyK4HuxOw9q4GmYjPrmUT2H2267zfJzsP +bAz5DYSrEf1hrCb1pjTL8mpZD8lIxQNWHT6E=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=ElyL5lmTxfJF7cWWQhWyXKzC/yAbrrZg3OtIsezgA/d1sbcI4pjqtP13D25fMzbHMI UMQ4DB0SaSRJ9DI+52o27ABZVXGPpRoftkUQgEtQRrtpyZXuHu2o9II67ITV2a+coB0M Z5oNFk2t+BcqhVLZ/cl5008IVjEoTS2Q83D8M=
2009/9/13 Hauke Heibel <hauke.heibel@xxxxxxxxxxxxxx>:
> Ok, I implemented the EIGEN_REF_TO_TEMPORARY stuff....
>
> I am just compiling it with gcc 4.4.1 and -std=c++0x. VS.net does not
> yet support c++0x features. It will come with the next version VC10.
>
> I had to change
>
> void swap(MatrixBase<OtherDerived> EIGEN_REF_TO_TEMPORARY & other);
>
> to
>
> void swap(MatrixBase<OtherDerived> EIGEN_REF_TO_TEMPORARY other);
>
> because it seems to be important for rvalue references that there are
> no spaces between the '&'s.
Hm, again, I wonder if it would be cleaner to do it via a template struct,
void swap(typename ei_ref_to_temporary<MatrixBase<OtherDerived> >::type other);
>
> It would be great, if somebody finds the time to check the patch.
The first thing I noticed is EIGE_ (missing N)
Take your time, i'm completely busy at the moment :)
Benoit