| [eigen] about JacobiSVD's options |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: [eigen] about JacobiSVD's options
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Tue, 15 Sep 2009 12:50:51 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:date:message-id:subject :from:to:content-type; bh=+vDJ/Z9ZpP+9YuvdrakvQziH+kgKFD+RPWLrwjiw1GU=; b=pLyM8gFhFdCM6SmepUAiRZMxZCMqGlM4A54PpOlBQDZSvwXlkJT0iYt33wH1onlNUY sSXBsnjbM9QoRF1fQnZXVx7kvGUYzpzz/9JxcrDbs7rY6dpvTmTYNhhv+B0AEz0/czkt uqkc6nMV5pmMJ7Q6a1AKY5VfYxfUamCbioa0A=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:date:message-id:subject:from:to:content-type; b=wkMb3zWOd387B9W0QLlNLQmJzrtGyaTjdr05BmCZ92aSpifb0xWY93buuiaaZ1buXW B6KQ0QHGtO+oGZXXEZT9jyWuTrozKF++maPrzFrqQ5QHQLRDAnh6hjKcSQceswt46kep rjHjJFtMBWWlNeKnIiZRDAVYcKQjpCsQ1J0jc=
hi,
the "Options" template parameter of JacobiSVD seems to be over-complicated.
What about removing the Square/MoreColsThanRows/etc. stuff from the
Option template parameter ? For small fixed sizes they can be
automatically extracted at compile time, and for dynamic sizes .. well
who care ? Moreover in the worst case, if the user use various matrix
shapes he can generate 3 instances of JacobiSVD for the same matrix
type...
Also, I'm wondering whether the ComputeU and ComputeV parameters could
be runtime parameters ? I doubt there is any performance difference,
but of course to be sure we should bench it. If I have time I'll do
it.
gael.