| Re: [eigen] Submitting patch to add pkg-config support |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Submitting patch to add pkg-config support
- From: Gael Guennebaud <gael.guennebaud@xxxxxxxxx>
- Date: Tue, 19 May 2009 21:02:19 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=T/Gw/xDpaOBja05YwPbT/DAwEvm8wyQuVDgElqLyRWA=; b=ijVP+xoOGZfUpfzYLuumevU4VkdyXaxetlwjdEsOtdwGQl08DMX9tSClfoJiZbEqo7 pisxWC0r4eAW6JzKDeCKq+TM9WtBGCph1skjEbLMHRcl4PQFQbUs8C1W3tIYE7qNV947 7fGayZUKuB2URrAyRn0cdOcdQtuJMakGFjI64=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=vB66Ae8R0vewAw5++w281aGV+lb93MUvPEc8Mlhc1ShrDf97dc6Q5k1ng/msdAL0U3 gCHMpWC59d4/5Px2iyyMIv0vFPhefjRJMP8clPNF/GyfJk+e5G+ZwIefnzayxxTn36eN yutWr45UU3dpR2MGHs3QcISWT1hEhYZ9+NHik=
I'd install it by default and perhaps add an option to disable it.
On Tue, May 19, 2009 at 8:47 PM, Benoit Jacob <jacob.benoit.1@xxxxxxxxx> wrote:
> This is currently inside a
>
> if(EIGEN_BUILD_PKGCONFIG)
>
> we should either
> - remove that if(), i.e. make it always happen
> or
> - add a option() entry for it (like for EIGEN_BUILD_... options)
>
> Opinions?
>
> Benoit
>
> 2009/5/19 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
>> Thanks, patch applied!
>>
>> To all: the beauty of HG is that i didn't even have to write a commit message!!
>>
>> 2009/5/19 Rhys Ulerich <rhys.ulerich@xxxxxxxxx>:
>>> (Second attempt-- sorry if a duplicate)
>>>
>>> Attached is an 'hg export' patch that adds pkg-config support against
>>> trunk. On a non-WIN32 system this installs lib/pkgconfig/eigen2.pc
>>> alongside the include/eigen2/... headers. The motivation for the
>>> patch is that installing the pkgconfig file allows autoconf users to
>>> easily see if Eigen is installed using the PKG_CHECK_MODULES macro.
>>>
>>> Please double check me on the CMake details-- I've not used it before.
>>>
>>> - Rhys
>>>
>>
>
>
>