| Re: [eigen] Submitting patch to add pkg-config support |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Submitting patch to add pkg-config support
- From: Benoit Jacob <jacob.benoit.1@xxxxxxxxx>
- Date: Tue, 19 May 2009 20:47:04 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type :content-transfer-encoding; bh=O9Ti/KvRLRx9vfHoKuXWwTIgrLqEF7Ec63HAgl1w6ZY=; b=MB5w+aU0H2EAy8nHjWXkNN3Jr713F+EqRc0PoTtCto5H2r1NZjs0/BgXwrpp2gsojx ZJ+nTmZiccSb6Y/PIDg1u75eSzyBvVWZplMHAt0oKW50t1bJC6QrkiBECt/8vqmUnnxu BK2uKOloPtSTOLAYnA3SfaW5wOkDkVwMzfMGM=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=KV3aDSyHWQaHPn19isGTwW6lO9lmciAmPpK/Q5fNGUn+5VTKYyaZX9Ic7CCoDI634j Zf9jf3Ak4SsutTClFlQ+YNVj0a13QjEg4uIHJpRrS/N0nqukQEvIshG8/X3y0lV4gOWw +M1wMC2T29HlvdAszAX7gZgalaLhxyT/YpHXo=
This is currently inside a
if(EIGEN_BUILD_PKGCONFIG)
we should either
- remove that if(), i.e. make it always happen
or
- add a option() entry for it (like for EIGEN_BUILD_... options)
Opinions?
Benoit
2009/5/19 Benoit Jacob <jacob.benoit.1@xxxxxxxxx>:
> Thanks, patch applied!
>
> To all: the beauty of HG is that i didn't even have to write a commit message!!
>
> 2009/5/19 Rhys Ulerich <rhys.ulerich@xxxxxxxxx>:
>> (Second attempt-- sorry if a duplicate)
>>
>> Attached is an 'hg export' patch that adds pkg-config support against
>> trunk. On a non-WIN32 system this installs lib/pkgconfig/eigen2.pc
>> alongside the include/eigen2/... headers. The motivation for the
>> patch is that installing the pkgconfig file allows autoconf users to
>> easily see if Eigen is installed using the PKG_CHECK_MODULES macro.
>>
>> Please double check me on the CMake details-- I've not used it before.
>>
>> - Rhys
>>
>