| Re: [eigen] Submitting patch to add pkg-config support |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/eigen Archives
]
- To: eigen@xxxxxxxxxxxxxxxxxxx
- Subject: Re: [eigen] Submitting patch to add pkg-config support
- From: Rhys Ulerich <rhys.ulerich@xxxxxxxxx>
- Date: Tue, 19 May 2009 13:55:19 -0500
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=d15Xq6jEVaSVIdbA0J7s9IbdqI3x4IDYH1JKQL5JYM0=; b=UTu5ISkUf6Fw5dpOoJuMQwvKV30t/CanrmobO+2lR4jg9ZwxGRABo8mZT9sziQc6Nh qUV08FIqFDTM82uOQj9iASsdxv1gQtS/6vU5gcXHmgD61X3LLBEfQ9XkmNznolDjeWoV xXvs5Ft9hhdaOH/HPiDYXOuel0+gHl5MSeCcY=
- Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=TlA9ZgDcp/2FiGUlJrs+ZSK+Jeifd7wZX0aSaNxPiHwehBF3cFT+it01WQ3NNugljX VbnFWHJq/69ulALiIDIMR1IJV0EBr+lTzHXupUWdHvAV+8FsSakCI7AjdcxyF+FDEHcR maGfR1DTFyNhJLjz7nxjFbzgk6VOKKkEGtDuY=
> This is currently inside a
>
> if(EIGEN_BUILD_PKGCONFIG)
>
> we should either
> - remove that if(), i.e. make it always happen
> or
> - add a option() entry for it (like for EIGEN_BUILD_... options)
>
> Opinions?
I wasn't sure on that setup. That build option is declared like
if(NOT WIN32)
option(EIGEN_BUILD_PKGCONFIG "Build pkg-config .pc file for Eigen" ON)
endif(NOT WIN32)
which is probably wrong. Maybe it should just be disabled by default
on WIN32 but always present.
- Rhys