Re: [AD] Update for gfx_mode_select/ex/filter behavior for A4.3.11+ |
[ Thread Index |
Date Index
| More lists.liballeg.org/allegro-developers Archives
]
- To: Coordination of admins/developers of the game programming library Allegro <alleg-developers@xxxxxxxxxx>
- Subject: Re: [AD] Update for gfx_mode_select/ex/filter behavior for A4.3.11+
- From: Elias Pschernig <elias.pschernig@xxxxxxxxxx>
- Date: Mon, 16 Mar 2009 15:51:56 +0100
On Mon, 2009-03-09 at 01:50 -0500, Edgar wrote:
> On 3/8/2009 9:05 AM, Elias wrote :
> > As long as it solves the problem, everything is fine to me - require
> > that all variables must be initialized to sane values or require that
> > they are all initialized to 0 or -1 (then no change in the code is
> > required), or require that if *card is GFX_AUTODETECT *w and *h can be
> > uninitialized (and don't read their values then).
> I just went with both options. I modified the functions to only search
> for initial values when the *parameter is not equivalent to 0 or -1, and
> included this behavior as well as a notification to initialize user
> variables in the documentation. Since searching for GFX_AUTODETECT (0)
> or GFX_TEXT (-1) would always result in not being on the list or being
> first on the list, then both values would always lead to using the first
> entry as the default in the selection list anyway. Take a look at the
> attached patch and let me know if this is suitable.
>
> Regarding any changes to api._tx, I don't see any changes related to
> 4.3.10 in there, but in changes._tx instead. Should I just leave
> documenting that part up to you?
>
Thanks, committed it, with a note in api._tx.
--
Elias Pschernig <elias@xxxxxxxxxx>