Re: [AD] Status of A5 on OS X (ppc)

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


On 17 Sep 2008, at 22:11, Evert Glebbeek wrote:
Should be four squares of different colours.

I was afraid you were going to say something like that...

Another endianesse bug, this time in ex_lockbitmap rather than Allegro itself. The problem was that the colour components were stored in a particular byte order, but AARRGGBB really means that the lowest- valued byte in a 32 bit word repersents blue, not necessarily the lowest byte in memory. The proper fix is to encode the memory in an endianesse independent way by using bitshift operators. The attached patch does this but I think it looks a bit clumsy. Comments wanted. I'll hopefully be doing something other than fixing endianesse bugs soon.

Evert

Attachment: ex_lockbitmap.diff
Description: Binary data



Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/