Re: [AD] Small problem with driver removals

[ Thread Index | Date Index | More lists.liballeg.org/allegro-developers Archives ]


Peter Wang wrote:
Quick grep: DIGI_* constants were used in alsa5.c, alsa9.c, arts.c, sgial.c, uesd.c, uoss.c, usnddrv.c. MIDI_* constants were used in alsamidi.c, uossmidi.c, usnddrv.c. GFX_* constants are still used in blit.c, cstretch.c, gsprite.c, istretch.c, modex.c, vga.c, vgaregs.c, rotate.c.

I'll check them and see what I can do.

Actually, the behaviour of whether driver constants are defined or not has been the same since 4.0.0 (at least), so we're not breaking anything if your changes are reverted.

The problem is that the docs never mentioned the driver defines disappearing if Allegro is compiled without support for that driver. Thusly, code which uses those defines without checking for them (which there is no indication that they had to be, and I think is ugly anyway) is now broken. The fact that it's been this way pre-4.0 has no real relevance.. we made changes to Allegro that causes valid Allegro programs to break, so we should fix it.

- Kitty Cat




Mail converted by MHonArc 2.6.19+ http://listengine.tuxfamily.org/