Re: [AD] X primitives patch

[Chris <kcat@xxxxxxxxxx>]

Peter Wang wrote:
> I tried both your first and second patch.  When I try the primitives 
> tests in the test program, the program can locks up.  It happens on at 
> least putpixel, hline and vline tests.  I tested with 16- and 32-bpp X 
> server colour depths.

Hmm.. I only had one lockup after starting work on this patch. It was 
when I switched from 8bpp to 32bpp (or vice versa) in 320x240 using the 
test program. However, it was before the screen cleared (I could see X 
in the background) and I could scroll the screen around with the mouse, 
which made me think Allegor didn't have full control of the X screen yet.

And I was able to run the test program's primitives tests without 
problems. Could you perhaps try a debug build and getting a backtrace of 
where it locks up?

> It looks like you got it right.  The implementation of _normal_rectfill 
> uses bmp->vtable->hfill, which is also used by floodfill, which is 
> affected by the drawing mode.

Cool.

- Kitty Cat