Re: [hatari-devel] Hatari screen dialog regression

[Eero Tamminen <oak@xxxxxxxxxxxxxx>]

Hi Nicolas,

On 29.7.2025 13.18, Eero Tamminen wrote:
> On 28.7.2025 22.41, Nicolas Pomarède wrote:
> > Le 28/07/2025 à 01:37, Eero Tamminen a écrit :
> > > Attached is patch that reworks the updated part of the dialog so that 
> > > it fits also into no-borders Hatari screen.  Attached screenshot 
> > > shows what it looks after that.
> >
> > If there's a problem with your setup, maybe others would have the 
> > same, so you can push this change. but it's still strange that I don't 
> > have this warning.
>
> Ok.  I'm doing some minor enhancement for it (and fixing the bug of it 
> giving truncated dir name to file selector).

The more I looked into screenshot handling, the more issues I noticed, 
not just in Frederic's changes, but in some of the earlier code, and how 
that interacts with his changes.

Attached is current patch set I'm working on (6 patches):
* Fix dialog size
* Fix file selector initial directory
* Do not allow selecting non-existing dir name [1]
* Fix ScreenSnapShot_SaveToFile() error checks
* Fix screenshot dir config vs. paths variables inconsistency
* Show default screenshot dir when user has no override for it
* Show AVI path selector (+ overwrite confirmation dialog) whenever 
recording is started from SDL GUI [2]
* And some other minor related code improvements

[1] As there's no support for creating missing dirs
[2] Instead of silently overriding user's configured AVI record path 
with screenshot dir...

Docs will also need an update (new screenshot etc).


	- Eero

Attachment: screenshot-fixes.zip
Description: Zip archive