Re: [hatari-devel] Hatari screen dialog regression

[Nicolas Pomarède <npomarede@xxxxxxxxxxxx>]

Le 28/07/2025 à 01:37, Eero Tamminen a écrit :
> Hi,
>
> On 23.7.2025 23.42, Nicolas Pomarède wrote:
> > your changes look ok to me, I merged your patches.
>
> When trying to invoke "Hatari screen" configuration dialog, I get now 
> this in console, and no dialog:
>      ERROR: Screen size too small for dialog!

Hi

that's strange, I don't get any error and the "Hatari screen" worked 
correctly for me (which is why I pushed the change).

> Otherwise it seemed to work.
>
> Attached is patch that reworks the updated part of the dialog so that it 
> fits also into no-borders Hatari screen.  Attached screenshot shows what 
> it looks after that.

If there's a problem with your setup, maybe others would have the same, 
so you can push this change. but it's still strange that I don't have 
this warning.

> > I thought this would retain your name as the patch author in the 
> > commit message when using framagit web interface, but it used my name, 
> > sorry about that.
>
> You did the merge, so merge commit is in your name (as it should), and 
> the merged commits _did_ retain correct author name etc.

but when I do "git log" or look at framagit log messages, I only see my 
name, not the author name. Wher edo you see it ?

Nicolas