| Re: [hatari-devel] -fno-common for macOS |
[ Thread Index |
Date Index
| More lists.tuxfamily.org/hatari-devel Archives
]
- To: hatari-devel@xxxxxxxxxxxxxxxxxxx, oak@xxxxxxxxxxxxxx
- Subject: Re: [hatari-devel] -fno-common for macOS
- From: Andreas Grabher <andreas_g86@xxxxxxxxxx>
- Date: Tue, 29 Jul 2025 17:27:37 +0200
- Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=icloud.com; s=1a1hai; bh=Yf7hpmRFtZg7kHV5exAhSwL5MXG7TvkFn3SXumXcEdw=; h=Content-Type:From:Mime-Version:Subject:Date:Message-Id:To:x-icloud-hme; b=e6z8I4QOwv7cIeFGyYHrr6JB36kz1wP/AMFPY1fvhMD4EKCubHJZ3zYT/2lnlu82wEuIVF/ra65XglsPY5PMx/9y0UVd5k5drxc4AAkDzxlSRHP9dEDL9yVitaXSOoRh4ZiHvqczSMvfGv+pmYkER6Oa9QP9lHg6Get2D+ZLg6UK0P83c8AjnmsKCY6KMgbaBVO0OwSG354VFoJlVZyJ4DjBU3qjb7P9xPQIIC0lllJHa/VfOd7DnLU/wB5H5lFQMun4jxpo34rPvVg9SbN4E5ns2nL6/01O/TrTUIjIF7V1WWBeI/GbY4usUnOcXLHJkfo1+sHy5Q6vrMZtcovExQ==
> Am 29.07.2025 um 15:38 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>
> Hi,
>
>> On 29.7.2025 15.36, Andreas Grabher wrote:
>> I am forwarding this in case you didn’t receive it from the mailing list.
>
> Did not receive it, but I see the updated patch in the ML archive (I assume you've tested it?):
> https://listengine.tuxfamily.org/lists.tuxfamily.org/hatari-devel/2025/07/msg00122.html
>
> Loooks good to me now!
>
>
> Thomas?
>
> - Eero
>
>> Andreas
>>> Anfang der weitergeleiteten Nachricht:
>>>
>>> Von: Andreas Grabher <andreas_g86@xxxxxxxxxx>
>>> Betreff: Aw: [hatari-devel] -fno-common for macOS
>>> Datum: 28. Juli 2025 um 13:26:37 MESZ
>>> An: hatari-devel@xxxxxxxxxxxxxxxxxxx
>>> Antwort an: hatari-devel@xxxxxxxxxxxxxxxxxxx
>>>
>>>
>>>
>>>> Am 28.07.2025 um 10:39 schrieb Eero Tamminen <oak@xxxxxxxxxxxxxx>:
>>>>
>>>> Hi Andreas,
>>>>
>>>> On 21.7.2025 12.45, Andreas Grabher wrote:
>>>>> it seems the latest compilers on macOS require -fno-common to be set in order to avoid a compilation error (ld: warning: reducing alignment of section __DATA,__common from 0x8000 to 0x4000 because it exceeds segment maximum alignment).
>>>>> Here is a post about the issue: https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2025-May/343169.html
>>>>> At the moment -fno-common is only set if ASAN is enabled but it should always be set.
>>>>
>>>> I did not receive rest of the discussion, but saw it on the mailing list archive.
>>>>
>>>> In your patch proposal, I think it would make more sense to use temporary local allocations instead of static object-global ones.
>>>>
>>>> (Either in stack, or alloc & free from heap.)
>>>>
>>>>
>>>> - Eero
>>>>
>>> Thank you for the review! This is a good suggestion. I modified the patch accordingly.
>>>
>> 
>
Yes, I tested it. Compiles and the macOS GUI works.