On Sun, Oct 13, 2024 at 9:13 AM Thomas Huth <
th.huth@xxxxxxxxx> wrote:
>
> You could also simply enable the "Cirrus-CI" for your repository in the
> github marketplace.
Thanks, I'll give it a try, though after trying to install it on my fork it seems to show me the hatari repository instead of my own for some reason. I'll try to see if I can fix that.
> > For the US TOS target, I have mapped the SDLK_EXCLAIM semantic to the only
> > key with an exclamation on it (1!) for that TOS. This also applies to DE,
> > UK, IT, SE, FI, NO, DK, NL, and will apply to PL when it's implemented.
>
> And that's what I don't understand, it's not really helpful for any user, I
> think.
The point is that SDLK_EXCLAIM semantic should be mapped to the best key it can for each TOS. Yes it's an imperfect mapping of SDLK_EXCLAIM to $02 (1!) but it is better than the nonsense mapping to $09 (8* or other symbol) for DE, UK, IT, SE, FI, NO, DK, NL. It's very minor, but it's slightly better, and it only takes 1 line of code to improve this semantic mapping from total nonsense to only slightly nonsense. Again, this applies only to the TOS regions where that mapping is relevant. Obviously French TOS can still use $09 (unless it wants to be one of the 3 "lost" key mappings I was asking about).
> Look, the old mixed Keymap_SymbolicToStScanCode() mapping function was serving us
> mostly fine for > 20 years (apart for TOS languages that differed too much from
> the US layout, but that should be fixed now with the additional new functions).
> I don't see the point of completely reworking that function just for the sake of
> it. Let's just keep it this way, and if a user of a specific language complains,
> we can still rework single keys there. But changing too much here might cause
> quite some friction for certain users that we were not thinking of.
Okay, then I can only say that this leaves no rationale I can follow for maintaining the "default" function other than keeping whatever you put there, so that's what I'll do in future suggestions. I think this makes every language override slightly more confusing, but it's not really important to me as long as the inputs and outputs are correct.
-- Brad Smith